This repository was archived by the owner on Sep 10, 2022. It is now read-only.
Conversation
Repository owner
deleted a comment from
codecov-io
Sep 20, 2017
tanem
reviewed
Sep 20, 2017
| @@ -64,64 +64,6 @@ declare module 'recompose' { | |||
|
|
|||
| declare type UnaryFn<A, R> = (a: A) => R | |||
|
|
|||
| declare type Compose = (<A, B, C, D, E, F, G, H, I>( | |||
Contributor
There was a problem hiding this comment.
Ha, nice to see this go, we hit the limit again not long after I submitted the earlier PR to extend it 😅
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 53 53
Lines 389 389
=======================================
Hits 346 346
Misses 43 43Continue to review full report at Codecov.
|
wuct
reviewed
Sep 22, 2017
| withProps(props => ({ | ||
| a: (props.a: string), | ||
| // Must $ ExpectError but not | ||
| // $ExpectError but not |
Contributor
There was a problem hiding this comment.
If it does throw error, we can remove but not as well.
neighborhood999
added a commit
to neighborhood999/recompose
that referenced
this pull request
Oct 25, 2017
* export `createEventHandlerWithConfig()` and add documentation. * Fix Prettier issues * Docs: Fix missing comma in type description for `createEventHandlerWithConfig()` * Docs: Add *WithConfig functions to TOC. * Use $Compose instead Compose (acdlite#523) * Use $Compose instead Compose * Update flow-bin dependencies * Allow React 16 (acdlite#530) Resolves acdlite#506. * recompose v0.25.1 * Updated base fiddle link (acdlite#534) Base fiddle was using a unpkg link pointed at the old (React 15) dist url but without a React version, so broke with the release of React 16. Now points to the correct location for React 16, with 16 specified (shouldn't break this way again). * Remove createEagerFactory and createEagerElement (acdlite#538) * recompose v0.26.0 * Fix grammar in API.md (acdlite#542) * Translate `createEventHandlerWithConfig()`
neighborhood999
added a commit
to neighborhood999/recompose
that referenced
this pull request
Nov 29, 2017
* export `createEventHandlerWithConfig()` and add documentation. * Fix Prettier issues * Docs: Fix missing comma in type description for `createEventHandlerWithConfig()` * Docs: Add *WithConfig functions to TOC. * Use $Compose instead Compose (acdlite#523) * Use $Compose instead Compose * Update flow-bin dependencies * Allow React 16 (acdlite#530) Resolves acdlite#506. * recompose v0.25.1 * Updated base fiddle link (acdlite#534) Base fiddle was using a unpkg link pointed at the old (React 15) dist url but without a React version, so broke with the release of React 16. Now points to the correct location for React 16, with 16 specified (shouldn't break this way again). * Remove createEagerFactory and createEagerElement (acdlite#538) * recompose v0.26.0 * Fix grammar in API.md (acdlite#542) * Translate `createEventHandlerWithConfig()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes almost all flow typing issues we had!!!!!
Waiting for flow-bin to be updated.