export createEventHandlerWithConfig() and add documentation.#522
export createEventHandlerWithConfig() and add documentation.#522wuct merged 4 commits intoacdlite:masterfrom acchou:master
createEventHandlerWithConfig() and add documentation.#522Conversation
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 53 53
Lines 389 389
=======================================
Hits 346 346
Misses 43 43Continue to review full report at Codecov.
|
|
|
||
| Returns an object with properties `handler` and `stream`. `stream` is an observable sequence, and `handler` is a function that pushes new values onto the sequence. Useful for creating event handlers like `onClick`. | ||
|
|
||
| ### `createEventHandlerWithConfig()` |
There was a problem hiding this comment.
Could you also add an entry to the TOC section?
There was a problem hiding this comment.
It turns out that mapPropsStreamWithConfig is also missing from the TOC section.
There was a problem hiding this comment.
Added these functions to the TOC, and also componentFromStreamWithConfig().
docs/API.md
Outdated
| toESObservable<T>: ?(stream: Stream<T>) => Observable<T>, | ||
| } | ||
| ) => (): { | ||
| handler: (value: T) => void |
type description for `createEventHandlerWithConfig()`
|
I noticed that I had to npm install |
|
@acchou Thanks! And yes, we can put them in |
Address issue #520. I'll also suggest a separate PR for typescript types in the appropriate repo.