This repository was archived by the owner on Nov 19, 2020. It is now read-only.
retain ReadOnlyDictionary reference instead of recreating instance on each property get#1
Merged
cesarsouza merged 1 commit intoaccord-net:masterfrom Dec 6, 2013
hanswolff:master
Merged
retain ReadOnlyDictionary reference instead of recreating instance on each property get#1cesarsouza merged 1 commit intoaccord-net:masterfrom hanswolff:master
cesarsouza merged 1 commit intoaccord-net:masterfrom
hanswolff:master
Conversation
… each property get ReadOnlyDictionary is only a wrapper around an existing dictionary so you can retain the reference instead of recreating new instances on each call. This change avoids a (minor) performance bottleneck if a user queries the properties in a loop and is not aware of the inner implementation.
cesarsouza
added a commit
that referenced
this pull request
Dec 6, 2013
retain ReadOnlyDictionary reference instead of recreating instance on each property get
Member
|
Thanks! Please let me know if you have any other suggestions and ideas for improving the project! |
Contributor
Author
|
Will do! Thank you for such a great framework! |
andrewkirillov
added a commit
that referenced
this pull request
May 1, 2015
Switch unit tests to NUnit
cesarsouza
pushed a commit
that referenced
this pull request
Aug 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadOnlyDictionary is only a wrapper around an existing dictionary so you can retain the reference instead of recreating new instances on each property get.
This change avoids a (minor) performance bottleneck if a user queries the properties in a loop and is not aware of the inner implementation.