Conversation
ccoVeille
commented
May 27, 2024
- chore: fix typo in file name
- chore: fix wrong comments and names
- chore: fix Markdown fenced block identifiers
- chore: fix typos
- chore: fix invalid aliases for Morse decode
- chore: fix acronyms case
|
Please find my reviews of your code |
interacive => interactive
8e0d0f8 to
c52a2d5
Compare
|
Hello @ccoVeille many thanks for your updates. |
|
Oh really? I will check when I would be in front of a computer. I'm on phone now |
|
I'm a bit surprised this reported nothing 🤔 |
|
Could you tellme what is failing according to you? It would help me later when I'll be ankle to check |
|
Please check this one. https://github.com/abhimanyu003/sttr/actions/runs/9260275381/job/25519173373?pr=44 --- FAIL: TestBase64Decode_Command (0.00s)
base64_test.go:127: Description() = Decode your Base64 text, want Decode your base64 text
--- FAIL: TestBase64URLDecode_Command (0.00s)
base64url_test.go:127: Description() = Decode your Base64 text with URL Safe, want Decode your base64 text with URL Safe
--- FAIL: TestSHA1Encode_Command (0.00s)
crypto_test.go:136: Description() = Get the SHA-1 checksum of your text, want Get the SHA1 checksum of your text
crypto_test.go:139: FilterValue() = SHA-1 Sum (sha1), want SHA1 Sum (sha1)
crypto_test.go:148: Title() = SHA-1 Sum (sha1), want SHA1 Sum (sha1)
--- FAIL: TestSHA256Encode_Command (0.00s)
crypto_test.go:217: Description() = Get the SHA-256 checksum of your text, want Get the SHA256 checksum of your text
crypto_test.go:220: FilterValue() = SHA-256 Sum (sha256), want SHA256 Sum (sha256)
crypto_test.go:229: Title() = SHA-256 Sum (sha256), want SHA256 Sum (sha256)
--- FAIL: TestSHA224Encode_Command (0.00s)
crypto_test.go:298: Description() = Get the SHA-224 checksum of your text, want Get the SHA224 checksum of your text
crypto_test.go:301: FilterValue() = SHA-224 Sum (sha224), want sha224 Sum (sha224)
crypto_test.go:310: Title() = SHA-224 Sum (sha224), want sha224 Sum (sha224)
--- FAIL: TestSHA384Encode_Command (0.00s)
crypto_test.go:379: Description() = Get the SHA-384 checksum of your text, want Get the SHA384 checksum of your text
crypto_test.go:382: FilterValue() = SHA-384 Sum (sha384), want sha384 Sum (sha384)
crypto_test.go:391: Title() = SHA-384 Sum (sha384), want sha384 Sum (sha384)
--- FAIL: TestSHA512Encode_Command (0.00s)
crypto_test.go:460: Description() = Get the SHA-512 checksum of your text, want Get the SHA512 checksum of your text
crypto_test.go:463: FilterValue() = SHA-512 Sum (sha-512), want SHA512 Sum (sha512)
crypto_test.go:469: Name() = sha-512, want sha512
crypto_test.go:472: Title() = SHA-512 Sum (sha-512), want SHA512 Sum (sha512)
--- FAIL: TestBcrypt_Command (0.00s)
crypto_test.go:549: Description() = Get the bcrypt hash of your text, want Get the Bcrypt hash of your text
crypto_test.go:552: FilterValue() = bcrypt Hash (bcrypt), want Bcrypt Hash (bcrypt)
crypto_test.go:561: Title() = bcrypt Hash (bcrypt), want Bcrypt Hash (bcrypt)
--- FAIL: TestMSGPACKToJSON_Command (0.00s)
json_test.go:254: FilterValue() = MSGPACK to JSON (msgpack-json), want MSGPACK To JSON (msgpack-json)
json_test.go:263: Title() = MSGPACK to JSON (msgpack-json), want MSGPACK To JSON (msgpack-json)
FAIL
FAIL github.com/abhimanyu003/sttr/processors 0.765s
FAIL |
|
So strange, now github reports me the errors while it wasn't earlier. Did you change or trigger something? Thanks anyway, it's clearer I will have a look when I can |
also use the official names: - bcrypt - Base32 - Base64 - Base64 URL - SHA-1 - SHA-256 - SHA-512 - macOS - ...
|
pushed back |
|
Im still unsure why the workflow is not triggered automatically https://github.com/abhimanyu003/sttr/actions/runs/9289818782/usage
Does it mean you have to manually launch them ? if so, why is this set up like this? |
|
Hello @ccoVeille
I have disabled it now. will review your PR and let you know :) |
|
This is looking quite good to me. 👍 thanks so much 🙇♂️ |
Strange setting I have never faced until now. I learned something today 🤣 |
| These are the few locations where `sttr` was highlighted, many thanks to all of you. | ||
| Please feel free to add any blogs/videos you may have made that discuss `sttr` to the list. | ||
| These are the few places where `sttr` got featured, many thanks to everyone. | ||
| If you have talked about `sttr` in your blog/video feel to add that to the list. |
There was a problem hiding this comment.
I'm doubtful about what happened here.
I didn't change these lines on purpose.
It looks like broken conflict resolution.
I'm sorry @abhimanyu003
There was a problem hiding this comment.
Yes, it looks like that. I will fix this. No worries on this. :)
| * [Youtube: The Giants of Open Source - DevOps Paradox](https://youtu.be/4nFRKbY_HVE?t=2529?ref=abhimanyu003/sttr) | ||
| * [YouTube: The Giants of Open Source - DevOps Paradox](https://youtu.be/4nFRKbY_HVE?t=2529?ref=abhimanyu003/sttr) | ||
| * [Terminal Trove - Tool of the Week](https://terminaltrove.com/sttr/?ref=abhimanyu003/sttr) | ||
| * [nixCraft](https://www.cyberciti.biz/open-source/sttr-awesome-linux-unix-command-tool-for-transformation-string/?ref=abhimanyu003/sttr) |
There was a problem hiding this comment.
Same with these 2 lines that got added
| return p.Title() | ||
| } | ||
|
|
||
| // HTMLEncode unescapes HTML to string |
There was a problem hiding this comment.
I'm going to push update for this.