Track wasmtime-py upstream fix in KNOWN_ISSUES (#599 bookmark) by aallan · Pull Request #600 · aallan/vera

aallan · 2026-05-07T16:06:50Z

Summary

New Runtime workarounds section in KNOWN_ISSUES.md mirroring the existing "CI workarounds" table format (workaround / where / rationale / remove-when / tracking-issue).
Captures the host_sleep _VeraExit(130) guard added in v0.0.137 as a bridge against bytecodealliance/wasmtime-py#336 (now fixed upstream by PR #337, awaiting PyPI release).
Bookmark issue #599 tracks the removal sequence: bump pyproject.toml first, then a separate follow-up PR drops the guard, closes #595.

Pure docs change; nothing on the test surface. Limitations-sync script confirms the table is consistent.

Test plan

python scripts/check_limitations_sync.py clean

Summary by CodeRabbit

Documentation
- Added documentation describing a shipped runtime workaround for interrupt handling, including references to the upstream issue, current implementation status, and the conditions under which the workaround will be removed once the upstream dependency is updated.

Added a "Runtime workarounds" section to KNOWN_ISSUES.md mirroring the existing "CI workarounds" pattern (workaround / where / rationale / remove-when / tracking-issue). Captures the host_sleep _VeraExit(130) guard added in v0.0.137 to bridge bytecodealliance/wasmtime-py#336. Companion bookmark issue #599 explains the removal sequence: 1. Bump pyproject.toml when wasmtime-py with 5c84f841 lands on PyPI (broader-surface change, lands first) 2. Separate follow-up PR drops the _VeraExit guard in host_sleep so KeyboardInterrupt propagates naturally 3. Closes #595 Co-Authored-By: Claude <noreply@anthropic.invalid>

coderabbitai · 2026-05-07T16:07:08Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c9537385-3377-4777-a148-3c370a6ec020

📥 Commits

Reviewing files that changed from the base of the PR and between 6ddaccb and 9718f8b.

📒 Files selected for processing (1)

KNOWN_ISSUES.md

📝 Walkthrough

Walkthrough

This PR adds a "Runtime workarounds" section to KNOWN_ISSUES.md documenting the shipped host_sleep guard that catches KeyboardInterrupt and raises _VeraExit(130), records upstream wasmtime‑py references, and specifies the condition for removing the workaround.

Runtime Workarounds Documentation

Layer / File(s)	Summary
Runtime Workaround Documentation `KNOWN_ISSUES.md`	Documents the shipped `host_sleep` `KeyboardInterrupt`→`_VeraExit(130)` guard that prevents wasmtime‑py trampoline malloc aborts. Includes upstream wasmtime‑py issue/PR references and specifies removal condition tied to a future wasmtime‑py version bump and `pyproject.toml` update.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Drop _VeraExit(130) workaround in host_sleep once wasmtime-py with #337 lands on PyPI #599: Documents the same host_sleep workaround and planned removal condition, directly related to this documentation entry.

Possibly related PRs

aallan/vera#594: Implements the host_sleep guard in runtime code; strongly related to this documentation update.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	Title accurately describes the main change: tracking the wasmtime-py upstream fix in KNOWN_ISSUES with issue `#599` bookmark reference.
Linked Issues check	✅ Passed	Documentation properly addresses `#595` objectives: tracks the host_sleep KeyboardInterrupt guard from v0.0.137, references upstream issues (`#336/`#337), and establishes removal sequence via `#599` bookmark.
Out of Scope Changes check	✅ Passed	Changes are strictly scoped to KNOWN_ISSUES.md documentation of existing v0.0.137 guard; no code alterations or unrelated modifications present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch claude/track-wasmtime-py-fix

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-05-07T16:08:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.92%. Comparing base (f63c031) to head (9718f8b).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files          59       59           
  Lines       22997    22997           
  Branches      259      259           
=======================================
  Hits        20910    20910           
  Misses       2080     2080           
  Partials        7        7

Flag	Coverage Δ
javascript	`57.36% <ø> (ø)`
python	`94.74% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@KNOWN_ISSUES.md`:
- Line 76: Update the table row to match reality: change the wasmtime-py version
claim from "43.0.0 (current pin)" to reflect the actual pyproject pin
("wasmtime>=44.0.0"), remove the nonexistent upstream references (issue `#336`, PR
`#337`, and commit 5c84f841) and any assertions about them being merged, and
replace the "Remove when" clause with an actionable condition (e.g., "Remove
after a wasmtime-py PyPI release containing the upstream fix is available and
pyproject.toml is bumped, then drop the guard per `#599`"); keep the note that
vera/codegen/api.py::host_sleep raises _VeraExit(130).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0363d701-7f22-4868-8881-80815b19a3d7

📥 Commits

Reviewing files that changed from the base of the PR and between f63c031 and 6ddaccb.

📒 Files selected for processing (1)

KNOWN_ISSUES.md

CodeRabbit on #600 caught two stale numbers in the new row: 1. Pin reference said "wasmtime-py 43.0.0 (current pin)"; actual pin in pyproject.toml is "wasmtime>=44.0.0". 43.0.0 was the version *installed* in the local venv (predating a recent re-pin) but not what the codebase requires. 2. "Remove when" condition said "above 43.0.0"; should be "above 44.0.0" because v44.0.0 was tagged before the upstream fix landed (verified: 91b8f149 v44.0.0 is two commits behind 5c84f841 main). No PyPI release currently includes the fix. Reworded the row to make those numbers right and to soften the "Remove when" into a clearer two-step removal sequence (release ships, bump pyproject, then a follow-up PR drops the guard per #599). Did NOT remove the upstream references (#336, #337, commit 5c84f841) that the rabbit flagged as "nonexistent" -- I verified all three exist via gh api and they're load-bearing for understanding the row. The rabbit cannot cross-repo-query bytecodealliance/wasmtime-py from the GitHub Action context, so its "nonexistent" assertion was a default- no-info safe assumption rather than a verified claim. Co-Authored-By: Claude <noreply@anthropic.invalid>

coderabbitai Bot reviewed May 7, 2026

View reviewed changes

Comment thread KNOWN_ISSUES.md Outdated

aallan merged commit 20f3ccb into main May 7, 2026
19 checks passed

aallan deleted the claude/track-wasmtime-py-fix branch May 7, 2026 16:25

coderabbitai Bot mentioned this pull request May 11, 2026

v0.0.144 release prep (recovery — should have been in #649) #651

Merged

3 tasks

coderabbitai Bot mentioned this pull request May 29, 2026

Drop _VeraExit(130) Ctrl-C workaround; centralize SIGINT handling on wasmtime 45 (#599) #709

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Track wasmtime-py upstream fix in KNOWN_ISSUES (#599 bookmark)#600

Track wasmtime-py upstream fix in KNOWN_ISSUES (#599 bookmark)#600
aallan merged 2 commits into
mainfrom
claude/track-wasmtime-py-fix

aallan commented May 7, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 7, 2026 •

edited

Loading

Walkthrough

Estimated code review effort

Possibly related issues

Possibly related PRs

Uh oh!

codecov Bot commented May 7, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

aallan commented May 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Possibly related issues

Possibly related PRs

Uh oh!

codecov Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

aallan commented May 7, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 7, 2026 •

edited

Loading

codecov Bot commented May 7, 2026 •

edited

Loading