Skip to content

Doc fixing#2

Closed
michaelneale wants to merge 2 commits intomainfrom
doc-fixing
Closed

Doc fixing#2
michaelneale wants to merge 2 commits intomainfrom
doc-fixing

Conversation

@michaelneale
Copy link
Copy Markdown
Collaborator

document how to run shell from source

@michaelneale michaelneale deleted the doc-fixing branch August 24, 2024 02:12
aegntic pushed a commit to aegntic/goose that referenced this pull request Oct 1, 2025
Add an impressive beginner-level recipe that automatically organizes and prioritizes tasks from various sources (files, emails, messages) into actionable todo lists. This recipe demonstrates practical AI-powered productivity enhancement.

Key Features:
- Multi-source task extraction (files, emails, messages, notes)
- Intelligent categorization by urgency and importance
- Project-based task organization
- Priority filtering and deadline tracking
- Actionable task transformation

Recipe Details:
- Uses exactly 1 MCP server (Filesystem) - beginner requirement
- Comprehensive parameter system for flexible task management
- Detailed prompt template with conditional logic
- Follows proper YAML structure and validation
- Addresses real-world productivity challenges

Hacktoberfest Contribution:
- Addresses issue aaif-goose#4933: Beginner Recipe Submission aaif-goose#2
- Meets all beginner recipe criteria
- Provides immediate value to users
- Demonstrates practical AI workflow automation

Impact:
- Helps users turn scattered information into organized action plans
- Reduces task overwhelm through intelligent prioritization
- Enhances productivity with automated task management
- Showcases practical AI-assisted workflow optimization

Signed-off-by: aegntic <team@aegntic.com>
aegntic pushed a commit to aegntic/goose that referenced this pull request Oct 1, 2025
Add an impressive beginner-level recipe that automatically organizes and prioritizes tasks from various sources (files, emails, messages) into actionable todo lists using AI-powered automation.

Key Features:
- Multi-source task extraction (files, emails, messages, notes)
- Intelligent categorization by urgency and importance
- Project-based task organization
- Priority filtering and deadline tracking
- Actionable task transformation

Recipe Details:
- Uses exactly 1 built-in MCP server (Filesystem) - beginner requirement
- Comprehensive parameter system for flexible task management
- Detailed prompt template with conditional logic
- Follows proper YAML structure and validation
- Addresses real-world productivity challenges

Technical Implementation:
- Fixed YAML syntax issues with proper string quoting
- Corrected extension type from 'stdio' to 'builtin'
- Ensured compliance with recipe validation requirements

Hacktoberfest Contribution:
- Addresses issue aaif-goose#4933: Beginner Recipe Submission aaif-goose#2
- Meets all beginner recipe criteria
- Provides immediate value to users
- Demonstrates practical AI workflow automation

Impact:
- Helps users turn scattered information into organized action plans
- Reduces task overwhelm through intelligent prioritization
- Enhances productivity with automated task management
- Showcases practical AI-assisted workflow optimization
aegntic added a commit to aegntic/goose that referenced this pull request Oct 1, 2025
Add an impressive beginner-level recipe that automatically organizes and prioritizes tasks from various sources (files, emails, messages) into actionable todo lists using AI-powered automation.

Key Features:
- Multi-source task extraction (files, emails, messages, notes)
- Intelligent categorization by urgency and importance
- Project-based task organization
- Priority filtering and deadline tracking
- Actionable task transformation

Recipe Details:
- Uses exactly 1 built-in MCP server (Filesystem) - beginner requirement
- Comprehensive parameter system for flexible task management
- Detailed prompt template with conditional logic
- Follows proper YAML structure and validation
- Addresses real-world productivity challenges

Hacktoberfest Contribution:
- Addresses issue aaif-goose#4933: Beginner Recipe Submission aaif-goose#2
- Meets all beginner recipe criteria
- Provides immediate value to users
- Demonstrates practical AI workflow automation

Impact:
- Helps users turn scattered information into organized action plans
- Reduces task overwhelm through intelligent prioritization
- Enhances productivity with automated task management
- Showcases practical AI-assisted workflow optimization
aegntic added a commit to aegntic/goose that referenced this pull request Oct 1, 2025
Add an impressive beginner-level recipe that automatically organizes and prioritizes tasks from various sources (files, emails, messages) into actionable todo lists using AI-powered automation.

Key Features:
- Multi-source task extraction (files, emails, messages, notes)
- Intelligent categorization by urgency and importance
- Project-based task organization
- Priority filtering and deadline tracking
- Actionable task transformation

Recipe Details:
- Uses exactly 1 built-in MCP server (Filesystem) - beginner requirement
- Comprehensive parameter system for flexible task management
- Detailed prompt template with conditional logic
- Follows proper YAML structure and validation
- Addresses real-world productivity challenges

Technical Implementation:
- Fixed YAML syntax issues with proper string quoting
- Corrected extension type to use built-in filesystem extension
- Ensured compliance with recipe validation requirements

Hacktoberfest Contribution:
- Addresses issue aaif-goose#4933: Beginner Recipe Submission aaif-goose#2
- Meets all beginner recipe criteria
- Provides immediate value to users
- Demonstrates practical AI workflow automation

Impact:
- Helps users turn scattered information into organized action plans
- Reduces task overwhelm through intelligent prioritization
- Enhances productivity with automated task management
- Showcases practical AI-assisted workflow optimization
aegntic added a commit to aegntic/goose that referenced this pull request Oct 1, 2025
Add an impressive beginner-level recipe that automatically organizes and prioritizes tasks from various sources (files, emails, messages) into actionable todo lists using AI-powered automation.

Key Features:
- Multi-source task extraction (files, emails, messages, notes)
- Intelligent categorization by urgency and importance
- Project-based task organization
- Priority filtering and deadline tracking
- Actionable task transformation

Recipe Details:
- Uses exactly 1 built-in MCP server (Filesystem) - beginner requirement
- Comprehensive parameter system for flexible task management
- Detailed prompt template with conditional logic
- Follows proper YAML structure and validation
- Addresses real-world productivity challenges

Hacktoberfest Contribution:
- Addresses issue aaif-goose#4933: Beginner Recipe Submission aaif-goose#2
- Meets all beginner recipe criteria
- Provides immediate value to users
- Demonstrates practical AI workflow automation

Impact:
- Helps users turn scattered information into organized action plans
- Reduces task overwhelm through intelligent prioritization
- Enhances productivity with automated task management
- Showcases practical AI-assisted workflow optimization
aegntic added a commit to aegntic/goose that referenced this pull request Oct 2, 2025
Add an impressive beginner-level recipe that automatically organizes and prioritizes tasks from various sources (files, emails, messages) into actionable todo lists using AI-powered automation.

Key Features:
- Multi-source task extraction (files, emails, messages, notes)
- Intelligent categorization by urgency and importance
- Project-based task organization
- Priority filtering and deadline tracking
- Actionable task transformation

Recipe Details:
- Uses exactly 1 built-in MCP server (Filesystem) - beginner requirement
- Comprehensive parameter system for flexible task management
- Detailed prompt template with conditional logic
- Follows proper YAML structure and validation
- Addresses real-world productivity challenges

Hacktoberfest Contribution:
- Addresses issue aaif-goose#4933: Beginner Recipe Submission aaif-goose#2
- Meets all beginner recipe criteria
- Provides immediate value to users
- Demonstrates practical AI workflow automation

Impact:
- Helps users turn scattered information into organized action plans
- Reduces task overwhelm through intelligent prioritization
- Enhances productivity with automated task management
- Showcases practical AI-assisted workflow optimization
aegntic added a commit to aegntic/goose that referenced this pull request Oct 2, 2025
Add an impressive beginner-level recipe that automatically organizes and prioritizes tasks from various sources (files, emails, messages) into actionable todo lists using AI-powered automation.

Key Features:
- Multi-source task extraction (files, emails, messages, notes)
- Intelligent categorization by urgency and importance
- Project-based task organization
- Priority filtering and deadline tracking
- Actionable task transformation

Recipe Details:
- Uses exactly 1 built-in MCP server (Filesystem) - beginner requirement
- Comprehensive parameter system for flexible task management
- Detailed prompt template with conditional logic
- Follows proper YAML structure and validation
- Addresses real-world productivity challenges

Hacktoberfest Contribution:
- Addresses issue aaif-goose#4933: Beginner Recipe Submission aaif-goose#2
- Meets all beginner recipe criteria
- Provides immediate value to users
- Demonstrates practical AI workflow automation

Impact:
- Helps users turn scattered information into organized action plans
- Reduces task overwhelm through intelligent prioritization
- Enhances productivity with automated task management
- Showcases practical AI-assisted workflow optimization

Signed-off-by: aegntic <research@aegntic.ai>
aegntic added a commit to aegntic/goose that referenced this pull request Oct 4, 2025
Add an impressive beginner-level recipe that automatically organizes and prioritizes tasks from various sources (files, emails, messages) into actionable todo lists using AI-powered automation.

Key Features:
- Multi-source task extraction (files, emails, messages, notes)
- Intelligent categorization by urgency and importance
- Project-based task organization
- Priority filtering and deadline tracking
- Actionable task transformation

Recipe Details:
- Uses exactly 1 built-in MCP server (Filesystem) - beginner requirement
- Comprehensive parameter system for flexible task management
- Detailed prompt template with conditional logic
- Follows proper YAML structure and validation
- Addresses real-world productivity challenges

Hacktoberfest Contribution:
- Addresses issue aaif-goose#4933: Beginner Recipe Submission aaif-goose#2
- Meets all beginner recipe criteria
- Provides immediate value to users
- Demonstrates practical AI workflow automation

Impact:
- Helps users turn scattered information into organized action plans
- Reduces task overwhelm through intelligent prioritization
- Enhances productivity with automated task management
- Showcases practical AI-assisted workflow optimization

Signed-off-by: aegntic <research@aegntic.ai>
aegntic added a commit to aegntic/goose that referenced this pull request Oct 16, 2025
Add an impressive beginner-level recipe that automatically organizes and prioritizes tasks from various sources (files, emails, messages) into actionable todo lists using AI-powered automation.

Key Features:
- Multi-source task extraction (files, emails, messages, notes)
- Intelligent categorization by urgency and importance
- Project-based task organization
- Priority filtering and deadline tracking
- Actionable task transformation

Recipe Details:
- Uses exactly 1 built-in MCP server (Filesystem) - beginner requirement
- Comprehensive parameter system for flexible task management
- Detailed prompt template with conditional logic
- Follows proper YAML structure and validation
- Addresses real-world productivity challenges

Hacktoberfest Contribution:
- Addresses issue aaif-goose#4933: Beginner Recipe Submission aaif-goose#2
- Meets all beginner recipe criteria
- Provides immediate value to users
- Demonstrates practical AI workflow automation

Impact:
- Helps users turn scattered information into organized action plans
- Reduces task overwhelm through intelligent prioritization
- Enhances productivity with automated task management
- Showcases practical AI-assisted workflow optimization

Signed-off-by: aegntic <research@aegntic.ai>
aharvard added a commit that referenced this pull request Nov 10, 2025
- Track trusted webContents IDs in a Set (trustedWebContentsIds)
- Only inject proxy token for requests from trusted webContents
- Validate webContents type (window/webview only) before trusting
- Validate webContents URL (file:// or dev server) before trusting
- Auto-cleanup trusted IDs when webContents destroyed
- Log warnings when untrusted webContents attempt proxy access
- Add type guard for undefined webContentsId
- Add comprehensive documentation explaining security flow

This prevents arbitrary webContents (compromised iframes, popups, etc.)
from automatically receiving the proxy authentication token.

Addresses security review item #2
arul-cc referenced this pull request in arul-cc/goose Nov 17, 2025
feat(anthropic): include custom provider configuration header in API …
bzqzheng added a commit to bzqzheng/goose that referenced this pull request Feb 4, 2026
This fixes the Fork Session issues where messages appeared to be gone or
the session seemed to update the existing one. The root cause was a race
condition where auto-submit fired before the forked conversation loaded.

Root Causes Fixed:
1. Auto-submit fired immediately, before messages loaded
2. Backend wasn't passed explicit conversation, potentially using stale data
3. User never saw the forked conversation history before it was modified

The Fix (Two Parts):

Part 1: Wait for Messages to Load (useAutoSubmit.ts)
- Check messages.length > 0 before auto-submitting for forked sessions
- This ensures the conversation history is loaded and visible
- If messages haven't loaded, return and wait for next render
- Once loaded, auto-submit fires with the edited message

Part 2: Pass conversation_so_far Explicitly (useChatStream.ts)
- When handleSubmit is called with existing messages, pass conversation_so_far
- This ensures backend uses the correct conversation state
- Prevents backend from loading potentially stale session data
- Fixes both fork and edit-in-place scenarios

Expected Behavior After Fix:
1. User clicks "Fork Session" with edited message
2. Backend creates forked session with conversation history
3. Frontend loads session, displays conversation history
4. Auto-submit waits until messages.length > 0
5. Auto-submit fires with edited message + explicit conversation
6. Backend processes with correct conversation context
7. New response streams back
8. User sees: [history] + [edited message] + [new response]

This maintains the expected automatic behavior while fixing the race
condition and ensuring data consistency.

Fixes both Bug aaif-goose#1 and Bug aaif-goose#2 from fork session investigation

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Bright Zheng <bright@squareup.com>
nkuhn-vmw pushed a commit to nkuhn-vmw/goose that referenced this pull request Feb 10, 2026
Implement a first-class provider for Tanzu AI Services, enabling
enterprise-managed LLM access through Cloud Foundry service bindings
with an OpenAI-compatible API.

- Add TanzuAIServicesProvider using OpenAiCompatibleProvider
- Support single-model and multi-model credential formats
- Support VCAP_SERVICES auto-detection for Cloud Foundry
- Implement config_url model discovery and capability filtering
- Register as Builtin provider in init.rs
- Add 14 unit tests and 10 integration tests (wiremock)
- Update providers.md documentation

Closes aaif-goose#1, aaif-goose#2, aaif-goose#3, aaif-goose#4, aaif-goose#5, aaif-goose#6, aaif-goose#7, aaif-goose#8, aaif-goose#12, aaif-goose#16

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
The parallel tool call merge (merge aaif-goose#2) was too aggressive — it merged
assistant+tool_call messages across separate model response boundaries.
When a multi-step conversation had reasoning_content on each step's
assistant message, merge aaif-goose#2 combined all tool_calls into a single
assistant message, losing reasoning_content from later steps and
creating an invalid conversation structure for Kimi thinking models.

The fix adds a check: stop merging when the next assistant message has
reasoning_content, which indicates a new model response rather than a
split parallel tool call from the same response.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Harrison <hcstebbins@gmail.com>
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
The parallel tool call merge (merge aaif-goose#2) was too aggressive — it merged
assistant+tool_call messages across separate model response boundaries.
When a multi-step conversation had reasoning_content on each step's
assistant message, merge aaif-goose#2 combined all tool_calls into a single
assistant message, losing reasoning_content from later steps and
creating an invalid conversation structure for Kimi thinking models.

The fix adds a check: stop merging when the next assistant message has
reasoning_content, which indicates a new model response rather than a
split parallel tool call from the same response.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Harrison <hcstebbins@gmail.com>
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
The parallel tool call merge (merge aaif-goose#2) was too aggressive — it merged
assistant+tool_call messages across separate model response boundaries.
When a multi-step conversation had reasoning_content on each step's
assistant message, merge aaif-goose#2 combined all tool_calls into a single
assistant message, losing reasoning_content from later steps and
creating an invalid conversation structure for Kimi thinking models.

The fix adds a check: stop merging when the next assistant message has
reasoning_content, which indicates a new model response rather than a
split parallel tool call from the same response.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Harrison <hcstebbins@gmail.com>
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
The parallel tool call merge (merge aaif-goose#2) was too aggressive — it merged
assistant+tool_call messages across separate model response boundaries.
When a multi-step conversation had reasoning_content on each step's
assistant message, merge aaif-goose#2 combined all tool_calls into a single
assistant message, losing reasoning_content from later steps and
creating an invalid conversation structure for Kimi thinking models.

The fix adds a check: stop merging when the next assistant message has
reasoning_content, which indicates a new model response rather than a
split parallel tool call from the same response.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Harrison <hcstebbins@gmail.com>
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
The parallel tool call merge (merge aaif-goose#2) was too aggressive — it merged
assistant+tool_call messages across separate model response boundaries.
When a multi-step conversation had reasoning_content on each step's
assistant message, merge aaif-goose#2 combined all tool_calls into a single
assistant message, losing reasoning_content from later steps and
creating an invalid conversation structure for Kimi thinking models.

The fix adds a check: stop merging when the next assistant message has
reasoning_content, which indicates a new model response rather than a
split parallel tool call from the same response.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Harrison <hcstebbins@gmail.com>
craigwalkeruk referenced this pull request in craigwalkeruk/custom-goose Feb 25, 2026
…/prototypes/agent-context-manager/vite-6.4.1

Bump vite from 6.3.5 to 6.4.1 in /research/prototypes/agent-context-manager
jamadeo pushed a commit that referenced this pull request Apr 13, 2026
…ture (#2)

* feat: scaffold Tauri + React app with window dragging and app icon

Sets up the goose2 desktop app with:
- Tauri 2 + React 19 + Vite + Tailwind CSS
- Custom titlebar with drag-to-move and double-click maximize/restore
- Window state persistence via tauri-plugin-window-state
- App icon ported from goose-desktop (cyan/amber yin-yang design)
- Theme system with dark/light/system modes
- Hermit toolchain (node, pnpm, biome, just, lefthook)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: add app shell layout with tabs, sidebar, and status bar

Adds the main application layout ported from goose2.0's visual design:
- TabBar with session tabs, home button, and sidebar toggle
- Collapsible sidebar with smooth width transition
- Status bar with model name, token count, and status indicator
- AppShell component wiring everything together

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: add settings modal with theme section + quality fixes

Settings:
- Settings modal with sidebar nav (Appearance, General, About)
- Theme selector (Light/Dark/System) wired to ThemeProvider
- Accent color picker and density selector (visual placeholders)
- Open via Cmd+, or Settings button in sidebar

Quality fixes:
- Fix stale state bug in tab close handler
- Fix unreachable useTheme guard, add OS theme change listener
- Improve accessibility (ARIA roles, labels, semantic elements)
- Add prefers-reduced-motion support
- Extract shared Tab type to features/tabs/types.ts

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove references to nonexistent theme-tokens module

The previous commit introduced imports for a theme-tokens module
that doesn't exist. Remove those imports and define the needed
types locally in ThemeProvider.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: wire up accent colors and density, add AGENTS.md

Theming:
- ThemeProvider now manages accent color and density (persisted to localStorage)
- Accent color applied via --color-accent CSS variable on :root
- Density applied via --density-spacing CSS variable (multiplier)
- AppearanceSettings uses ThemeProvider context instead of local state
- Tailwind config maps accent color variable
- Settings modal animations enhanced to match goose2.0 reference
- Component classes updated to use semantic token names

Documentation:
- AGENTS.md captures all project conventions, patterns, and decisions

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: replace ambiguous Tailwind arbitrary durations with config values

Add duration-400 and duration-600 to Tailwind config to avoid
ambiguous class warnings from arbitrary value syntax.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: sidebar minimizes to icon strip instead of hiding

The sidebar now shrinks to a 48px icon-only column when toggled,
instead of disappearing completely. Icons stay visible with tooltips,
labels and section headers are hidden. Smooth width transition.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: improve settings button alignment and styling in sidebar

Match goose2.0's footer pattern with proper padding, full-opacity
border, flex alignment, and smooth transition between states.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: add home screen with clock, greeting, and hidden status bar

Home screen shows a live digital clock, time-based greeting, and
placeholder chat input. Status bar hides when on the home view
(no active tab), matching goose2.0's clean home experience.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: improve home screen to match goose2.0, add chat view

Home screen: large mono clock with AM/PM, time-based greeting,
goose2.0-style chat input (rounded-2xl, shadow-lg, model badge).
Chat view: input at bottom with scrollable messages area.
Home vs chat differentiated by active tab state.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: chat view now fills the full available height

Remove flex from main element so child components can properly
resolve h-full against the block parent.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: add testing infrastructure (Vitest, Playwright, CI)

Testing:
- Vitest for unit/component tests with jsdom + React Testing Library
- 13 tests across 3 test files (ThemeProvider, cn utility, HomeScreen)
- Playwright for E2E smoke tests (4 tests)
- Test setup with matchMedia mock for jsdom

Tooling:
- Just targets: test, test-watch, test-coverage, test-e2e
- Lefthook pre-push now runs unit tests
- CI gate includes tests

CI/CD:
- GitHub Actions workflow with 4 jobs: lint, test, desktop, rust-lint
- Playwright artifacts uploaded on failure
- Rust caching for faster builds

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: resolve all Biome formatting and lint issues

Auto-format all files with Biome. Fix lint issues:
- Add type="button" to all interactive buttons
- Replace span[role=button] with proper button element
- Add dialog role to settings modal
- Biome-ignore for standard accessibility !important pattern

All checks pass: pnpm check, pnpm test, pnpm build.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* chore: add src-tauri/target/ to .gitignore

Prevent Rust/Tauri build artifacts from being committed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: exclude Tauri generated schemas from Biome formatting

* chore: update .gitignore for full project coverage

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: pin CI actions to commit SHAs for Semgrep compliance

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: resolve CI failures and improve lefthook auto-formatting

- Fix dtolnay/rust-toolchain action SHA (was invalid, causing all Rust
  CI jobs to fail)
- Fix Biome folder ignore pattern (remove trailing /**)
- Update lefthook pre-commit to auto-format with biome instead of
  just checking

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: use vite preview directly with explicit host for E2E server

The Playwright webServer was using `pnpm preview --port 4173` which
invoked vite preview without --host, causing it to bind to localhost
(IPv6 ::1) instead of 127.0.0.1. This caused ERR_CONNECTION_REFUSED
in CI and locally. Switch to npx vite preview with --host 127.0.0.1
and --strictPort to ensure reliable binding.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: gracefully handle non-Tauri browser environment

Check for Tauri runtime before calling window APIs so the app
renders correctly in browser-based E2E tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: make E2E smoke tests more robust with longer timeouts

- Add 10s timeout for element visibility (CI can be slow to render)
- Use .first() for model badge to handle multiple matches
- Fix strict mode violation for duplicate text matches

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: smooth transition for status bar show/hide

Status bar now slides and fades in/out with a 300ms transition
instead of appearing/disappearing abruptly when switching views.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: use dynamic import for Tauri API to prevent browser crash

Static import of @tauri-apps/api/window fails at module load time
in non-Tauri environments. Use dynamic import() guarded by
__TAURI_INTERNALS__ check so the app renders in Playwright.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: use python http.server for E2E tests, start with empty tabs

Switch Playwright webServer from npx vite preview to python3 http.server
for more reliable static file serving in CI. Start app with no tabs
open (home screen by default).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: align E2E setup with Sprout's proven configuration

- Use url instead of port for webServer readiness check
- Remove -b 127.0.0.1 flag from python http.server command
- Add explicit cwd to webServer config
- Use pnpm exec instead of npx for Playwright in CI

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* chore: remove unused @tauri-apps/plugin-opener JS dependency

The Rust-side tauri-plugin-opener is still registered, but the JS
binding package was never imported from frontend code. Removing it
keeps the dependency list honest. Dark mode colors already match
goose2.0 — no changes needed there.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Surendhar-N-D pushed a commit to Surendhar-N-D/goose that referenced this pull request Apr 16, 2026
…_fix

add recipe instruction to agent initialization process
jramnani added a commit to jramnani/goose that referenced this pull request May 6, 2026
Problem:
Inline code text rendered as nearly invisible light grey (#cbd1d6) on white
background in the light theme. Contrast ratio was 1.54:1 — far below the
WCAG 2.1 AA minimum of 4.5:1.

Root cause:
1. The base .bg-inline-code class used --color-neutral-200 (#cbd1d6), a color
   designed for dark backgrounds, with no light/dark theme differentiation.
2. The accent color override used parent-specific selectors (p > code, li > code)
   which failed in many common contexts:
   - Inline code inside <strong> (bold text)
   - Inline code inside <em> (italic text)
   - Inline code inside <td>/<th> (table cells)
   - Inline code inside <a> (links)
   - Any other nesting beyond direct child of <p> or <li>

Fix:
- Apply the accessible accent color directly on the base .bg-inline-code class
  so it works in ALL contexts (tables, headings, bold, italic, links, etc.)
- Light theme: #c2410c (4.78:1 contrast ✅ AA) with subtle #f4f6f7 background.
- Dark theme: #ff7235 (4.51:1 contrast ✅ AA) with #32353b background.
- Removed the parent-specific selectors entirely — no longer needed since the
  base class now carries the correct color everywhere.

---
Session Context:
- User noticed the poor contrast from a real session where Goose output included
  inline code inside bold text in numbered lists AND inside table cells.
- Key insight aaif-goose#1: the direct-child selector (>) was the initial trigger — inline
  code nested inside <strong> within list items never matched the orange override.
- Key insight aaif-goose#2: even after fixing the direct-child issue with descendant
  selectors, inline code in table cells (<td>) was still grey because only
  p/li ancestors were in the selector. The correct fix is to put the accessible
  color on the base class itself.
- The user is running Goose installed via Homebrew; there is no user-facing
  config to customize theme colors, so this requires a source code fix or PR.
- User plans to file this as a public issue/discussion on the Goose project.
- We verified contrast ratios programmatically against WCAG 2.1 AA/AAA standards.
- User confirmed the patched version looks correct after testing locally.
- Branch: jramnani-1.33.1 (based on release 1.33.1 patch)
- Next steps: User may submit this as a PR or issue upstream with screenshots.
jramnani added a commit to jramnani/goose that referenced this pull request May 6, 2026
Problem:
Inline code text rendered as nearly invisible light grey (#cbd1d6) on white
background in the light theme. Contrast ratio was 1.54:1 — far below the
WCAG 2.1 AA minimum of 4.5:1.

Root cause:
1. The base .bg-inline-code class used --color-neutral-200 (#cbd1d6), a color
   designed for dark backgrounds, with no light/dark theme differentiation.
2. The accent color override used parent-specific selectors (p > code, li > code)
   which failed in many common contexts:
   - Inline code inside <strong> (bold text)
   - Inline code inside <em> (italic text)
   - Inline code inside <td>/<th> (table cells)
   - Inline code inside <a> (links)
   - Any other nesting beyond direct child of <p> or <li>

Fix:
- Apply the accessible accent color directly on the base .bg-inline-code class
  so it works in ALL contexts (tables, headings, bold, italic, links, etc.)
- Light theme: #c2410c (4.78:1 contrast ✅ AA) with subtle #f4f6f7 background.
- Dark theme: #ff7235 (4.51:1 contrast ✅ AA) with #32353b background.
- Removed the parent-specific selectors entirely — no longer needed since the
  base class now carries the correct color everywhere.

---
Session Context:
- User noticed the poor contrast from a real session where Goose output included
  inline code inside bold text in numbered lists AND inside table cells.
- Key insight aaif-goose#1: the direct-child selector (>) was the initial trigger — inline
  code nested inside <strong> within list items never matched the orange override.
- Key insight aaif-goose#2: even after fixing the direct-child issue with descendant
  selectors, inline code in table cells (<td>) was still grey because only
  p/li ancestors were in the selector. The correct fix is to put the accessible
  color on the base class itself.
- The user is running Goose installed via Homebrew; there is no user-facing
  config to customize theme colors, so this requires a source code fix or PR.
- User plans to file this as a public issue/discussion on the Goose project.
- We verified contrast ratios programmatically against WCAG 2.1 AA/AAA standards.
- User confirmed the patched version looks correct after testing locally.
- Branch: jramnani-1.33.1 (based on release 1.33.1 patch)
- Next steps: User may submit this as a PR or issue upstream with screenshots.
jramnani added a commit to jramnani/goose that referenced this pull request May 8, 2026
Problem:
Inline code text rendered as nearly invisible light grey (#cbd1d6) on white
background in the light theme. Contrast ratio was 1.54:1 — far below the
WCAG 2.1 AA minimum of 4.5:1.

Root cause:
1. The base .bg-inline-code class used --color-neutral-200 (#cbd1d6), a color
   designed for dark backgrounds, with no light/dark theme differentiation.
2. The accent color override used parent-specific selectors (p > code, li > code)
   which failed in many common contexts:
   - Inline code inside <strong> (bold text)
   - Inline code inside <em> (italic text)
   - Inline code inside <td>/<th> (table cells)
   - Inline code inside <a> (links)
   - Any other nesting beyond direct child of <p> or <li>

Fix:
- Apply the accessible accent color directly on the base .bg-inline-code class
  so it works in ALL contexts (tables, headings, bold, italic, links, etc.)
- Light theme: #c2410c (4.78:1 contrast ✅ AA) with subtle #f4f6f7 background.
- Dark theme: #ff7235 (4.51:1 contrast ✅ AA) with #32353b background.
- Removed the parent-specific selectors entirely — no longer needed since the
  base class now carries the correct color everywhere.

---
Session Context:
- User noticed the poor contrast from a real session where Goose output included
  inline code inside bold text in numbered lists AND inside table cells.
- Key insight aaif-goose#1: the direct-child selector (>) was the initial trigger — inline
  code nested inside <strong> within list items never matched the orange override.
- Key insight aaif-goose#2: even after fixing the direct-child issue with descendant
  selectors, inline code in table cells (<td>) was still grey because only
  p/li ancestors were in the selector. The correct fix is to put the accessible
  color on the base class itself.
- The user is running Goose installed via Homebrew; there is no user-facing
  config to customize theme colors, so this requires a source code fix or PR.
- User plans to file this as a public issue/discussion on the Goose project.
- We verified contrast ratios programmatically against WCAG 2.1 AA/AAA standards.
- User confirmed the patched version looks correct after testing locally.
- Branch: jramnani-1.33.1 (based on release 1.33.1 patch)
- Next steps: User may submit this as a PR or issue upstream with screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants