fix: Fixing missing push configuration after normalization for rest transport by bartek-gralewicz · Pull Request #346 · a2aproject/a2a-js

bartek-gralewicz · 2026-03-10T11:09:42Z

Description

This PR solves a bug that was mentioned here: #336.

The issue occurred due to missing mapping of pushNotificationConfig in the mapping method. Since mapping is no longer needed, all logic related to field mapping was removed in this PR.

Changes:

Extension to an existing unit test to check for pushNotificationConfig presence. This test failed as expected before removing the normalization, hence, catching the bug for the future.
Remove rest types and related unions.
Removed snake_case cases from unit testes.
Removed normalization functions but remained field checks to align with currently existing unit tests.

Fixes #336

…ormalization happens. The test purposely fails at the moment

…nit testes. Removed normalization functions but remained field checks to align with currently existing unit tests.

github-actions · 2026-03-10T11:58:39Z

🧪 Code Coverage

⬇️ Download Full Report

	Main	PR	Delta
src/server/transports/rest/rest_transport_handler.ts	96.56%	98.78%	🟢 +2.22%
Total	80.99%	80.84%	🔴 -0.15%

Generated by coverage-comment.yml

gemini-code-assist · 2026-03-10T12:01:28Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the REST transport handler where push notification configurations were not being correctly processed. The core of the fix involves a significant simplification of the codebase by removing all explicit normalization logic that previously handled snake_case to camelCase conversions. This change streamlines the data flow, ensuring that parameters are handled directly, and improves the robustness of the system by adding explicit validation checks where normalization was removed. The updated test suite validates these changes and prevents regressions.

Highlights

Bug Fix: Resolved a bug where pushNotificationConfig was not correctly mapped due to missing normalization logic in the REST transport handler.
Code Simplification: Removed all logic related to field mapping and normalization, as it was no longer needed, simplifying the RestTransportHandler.
Type System Refinement: Eliminated REST-specific types and related unions that previously handled snake_case to camelCase conversion.
Test Suite Update: Updated unit tests to reflect the removal of snake_case normalization and added a new test case to specifically catch the bug related to pushNotificationConfig.

Changelog

src/server/transports/rest/rest_transport_handler.ts
- Removed imports for REST-specific types like Part, FileWithBytes, FileWithUri, and all Rest* types.
- Modified sendMessage and sendMessageStream methods to directly use MessageSendParams and include explicit validation for required message fields.
- Modified setTaskPushNotificationConfig to directly use TaskPushNotificationConfig and include explicit validation for taskId and pushNotificationConfig.
- Removed all private normalization methods, including normalizeMessageParams, normalizePart, normalizeFile, normalizeMessage, normalizeMessageSendParams, and normalizeTaskPushNotificationConfig.
src/server/transports/rest/rest_types.ts
- Removed the file defining REST-specific snake_case types and input unions.
test/server/rest_transport_handler.spec.ts
- Removed test cases that validated snake_case message input normalization.
- Updated sendMessage configuration test to use camelCase fields and include pushNotificationConfig.
- Removed test cases that validated snake_case configuration normalization for setTaskPushNotificationConfig.
- Removed test cases that validated snake_case file part normalization.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request updates a test case in test/server/rest_transport_handler.spec.ts to include new blocking and push_notification_config properties within the configuration object. These properties are added to both the test input and the expected values in the sendMessage assertion, reflecting an update to the RestTransportHandler's configuration handling.

src/server/transports/rest/rest_transport_handler.ts

…_normalization

🤖 I have created a release *beep* *boop* --- ## [0.3.12](v0.3.11...v0.3.12) (2026-03-10) ### Bug Fixes * Fixing missing push configuration after normalization for rest transport ([#346](#346)) ([54ac8c4](54ac8c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Apparently the code removed in #346 wasn't "dead", this method was missed in #292.

…352) Apparently the code removed in #346 wasn't "dead", this method wasn't properly migrated in #292. Tests are updated to cover this. Fixes #336

…ransport (a2aproject#346) # Description This PR solves a bug that was mentioned here: a2aproject#336. The issue occurred due to missing mapping of `pushNotificationConfig` in the mapping method. Since mapping is no longer needed, all logic related to field mapping was removed in this PR. Changes: - Extension to an existing unit test to check for `pushNotificationConfig` presence. This test failed as expected before removing the normalization, hence, catching the bug for the future. - Remove rest types and related unions. - Removed snake_case cases from unit testes. - Removed normalization functions but remained field checks to align with currently existing unit tests. Fixes a2aproject#336 --------- Co-authored-by: Bartek Gralewicz <bgralewicz@google.com>

🤖 I have created a release *beep* *boop* --- ## [0.3.12](a2aproject/a2a-js@v0.3.11...v0.3.12) (2026-03-10) ### Bug Fixes * Fixing missing push configuration after normalization for rest transport ([a2aproject#346](a2aproject#346)) ([54ac8c4](a2aproject@54ac8c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…2aproject#352) Apparently the code removed in a2aproject#346 wasn't "dead", this method wasn't properly migrated in a2aproject#292. Tests are updated to cover this. Fixes a2aproject#336

bartek-gralewicz added 2 commits March 10, 2026 11:03

Added a unit test that catches the missing push configuration after n…

acb45e5

…ormalization happens. The test purposely fails at the moment

Remove rest types and related unions. Removed snake_case cases from u…

2f15102

…nit testes. Removed normalization functions but remained field checks to align with currently existing unit tests.

Remove outdated comment.

cf385de

bartek-gralewicz marked this pull request as ready for review March 10, 2026 12:07

bartek-gralewicz requested a review from a team as a code owner March 10, 2026 12:07

bartek-gralewicz requested a review from ishymko March 10, 2026 12:07

gemini-code-assist bot reviewed Mar 10, 2026

View reviewed changes

ishymko approved these changes Mar 10, 2026

View reviewed changes

src/server/transports/rest/rest_transport_handler.ts Show resolved Hide resolved

bartek-gralewicz added 2 commits March 10, 2026 14:54

Extracted a function to remove code duplication.

5408854

Merge remote-tracking branch 'origin' into bgralewicz/fix_push_config…

8b21fdd

…_normalization

bartek-gralewicz merged commit 54ac8c4 into main Mar 10, 2026
14 checks passed

bartek-gralewicz deleted the bgralewicz/fix_push_config_normalization branch March 10, 2026 15:22

a2a-bot mentioned this pull request Mar 10, 2026

chore(main): release 0.3.12 #348

Merged

bartek-gralewicz added a commit that referenced this pull request Mar 12, 2026

Apply changes from #346 bugfix PR.

8fd779a

ishymko added a commit that referenced this pull request Mar 13, 2026

fix: properly parse ProtoJSON body for POST pushNotificationConfigs

f3d7188

Apparently the code removed in #346 wasn't "dead", this method was missed in #292.

ishymko mentioned this pull request Mar 13, 2026

fix: properly parse ProtoJSON body for POST pushNotificationConfigs #352

Merged

ishymko added a commit that referenced this pull request Mar 13, 2026

fix: properly parse ProtoJSON body for POST pushNotificationConfigs

5c0a1a8

Apparently the code removed in #346 wasn't "dead", this method was missed in #292.

ishymko added a commit that referenced this pull request Mar 13, 2026

fix: properly parse ProtoJSON body for POST pushNotificationConfigs

d01ab3a

Apparently the code removed in #346 wasn't "dead", this method was missed in #292.

ishymko added a commit that referenced this pull request Mar 13, 2026

fix: properly parse ProtoJSON body for POST pushNotificationConfigs

8937790

Apparently the code removed in #346 wasn't "dead", this method was missed in #292.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fixing missing push configuration after normalization for rest transport#346

fix: Fixing missing push configuration after normalization for rest transport#346
bartek-gralewicz merged 5 commits intomainfrom
bgralewicz/fix_push_config_normalization

bartek-gralewicz commented Mar 10, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Mar 10, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bartek-gralewicz commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Code Coverage

Uh oh!

gemini-code-assist bot commented Mar 10, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bartek-gralewicz commented Mar 10, 2026 •

edited

Loading

github-actions bot commented Mar 10, 2026 •

edited

Loading