fix: Populate the ServerCallContext user param when a new ServerCallContext is created#200
Conversation
Summary of ChangesHello @guglielmo-san, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue in the request handling mechanism where user information was not consistently carried over when a new server call context was instantiated. By explicitly passing the user object during context creation, the fix prevents data loss and ensures that user-specific data remains available for subsequent operations within the request. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where the user property was lost from the ServerCallContext when requested extensions were present. The changes correctly fix this issue by ensuring the user is preserved in two scenarios:
- When a new
ServerCallContextis created, theuserfrom the original context is now correctly passed along. - The
newServerCallContextis now initialized with the originalcontext, which prevents the user from being dropped if no extensions are requested but a context with a user exists.
The fix is direct, easy to understand, and correctly resolves the bug. I've added one suggestion to include a regression test to ensure this bug doesn't reappear in the future.
…ontext is created (a2aproject#200) This PR is a fix for the bug caused by the user being deleted when the request is containing requested extensions, as a new ServerCallContext was created without copying the `context.user`. Fixes a2aproject#199 🦕 PRs a2aproject#171, a2aproject#195 BEGIN_COMMIT_OVERRIDE refactor: Populate the ServerCallContext user param when a new ServerCallContext is created END_COMMIT_OVERRIDE
…ontext is created (a2aproject#200) This PR is a fix for the bug caused by the user being deleted when the request is containing requested extensions, as a new ServerCallContext was created without copying the `context.user`. Fixes a2aproject#199 🦕 PRs a2aproject#171, a2aproject#195 BEGIN_COMMIT_OVERRIDE refactor: Populate the ServerCallContext user param when a new ServerCallContext is created END_COMMIT_OVERRIDE
Description
This PR is a fix for the bug caused by the user being deleted when the request is containing requested extensions, as a new ServerCallContext was created without copying the
context.user.Fixes #199 🦕
PRs #171, #195
BEGIN_COMMIT_OVERRIDE
refactor: Populate the ServerCallContext user param when a new ServerCallContext is created
END_COMMIT_OVERRIDE