Skip to content

fix: ensure correct concurrent cancellation results#286

Merged
yarolegovich merged 4 commits intorelease/spec-v0from
yarolegovich/fix-cancel-result
Mar 19, 2026
Merged

fix: ensure correct concurrent cancellation results#286
yarolegovich merged 4 commits intorelease/spec-v0from
yarolegovich/fix-cancel-result

Conversation

@yarolegovich
Copy link
Copy Markdown
Member

@yarolegovich yarolegovich commented Mar 19, 2026 •
edited
Loading

re #245

the fix was not working for concurrent cancellations because errors.Is check was not passing in the added logic

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Mar 19, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the robustness and testability of concurrent task cancellation logic. It introduces new end-to-end tests to cover edge cases where tasks might transition to a final state during a cancellation attempt, and refines the test executor utility to provide more control over execution flow for these complex scenarios. The changes ensure that cancellation outcomes are correctly handled and reported, especially under concurrent conditions.

Highlights

  • Enhanced Concurrent Cancellation Testing: Two new end-to-end tests were added to thoroughly validate concurrent cancellation scenarios, specifically addressing error handling when a task becomes terminal before cancellation and ensuring consistent results from multiple concurrent cancellation attempts.
  • Improved Error Context for Concurrent Task Modification: The error returned when a task moves to a terminal state before it can be cancelled now includes a wrapped a2a.ErrConcurrentTaskModification, providing clearer context for concurrent issues.
  • Refactored Test Executor for Granular Control: The TestAgentExecutor was refactored to explicitly implement Execute, Cleanup, and Cancel methods, and a new ControlChannels mechanism was introduced to allow for precise orchestration of test executor behavior during complex concurrent tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces fixes for concurrent task cancellations and adds valuable end-to-end tests to validate these scenarios. The changes to internal/taskupdate/manager.go and the new test utilities in internal/testutil/testexecutor/executor.go are well-implemented. However, I've identified a potential panic in one of the new tests due to a race condition not being handled safely, and a misleading assertion message in another. My feedback aims to improve the robustness and clarity of these new tests.

@yarolegovich yarolegovich merged commit 893aa2a into release/spec-v0 Mar 19, 2026
4 checks passed
@yarolegovich yarolegovich deleted the yarolegovich/fix-cancel-result branch March 19, 2026 14:02
yarolegovich added a commit that referenced this pull request Mar 19, 2026
@yarolegovich
fix: ensure correct concurrent cancellation results (#286)
46bc542 
the fix was not working for concurrent cancellations because `errors.Is`
check was not passing in the added logic

re #245
nahapetyan-serob
nahapetyan-serob reviewed Mar 19, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nahapetyan-serob nahapetyan-serob nahapetyan-serob left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yarolegovich @nahapetyan-serob