fix: remove keep-alive messages#100
Conversation
Summary of ChangesHello @xenv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical compatibility concern by removing the Server-Sent Events (SSE) keep-alive message mechanism. While the previous implementation adhered to the SSE standard, its interaction with the python-sdk caused issues. By disabling these messages, the system ensures seamless integration and operation with the Python client, prioritizing practical compatibility over strict adherence to a non-critical SSE feature. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the Server-Sent Events (SSE) keep-alive messages to improve compatibility with a Python SDK. The changes correctly remove the keep-alive ticker logic from a2asrv/jsonrpc.go and the corresponding WriteKeepAlive function from internal/sse/sse.go. However, the removal of WriteKeepAlive will cause a compilation error because it is still being used in a test file. This critical issue needs to be addressed.
085d0b9 to
cf62fa1
Compare
🤖 I have created a release *beep* *boop* --- ## [0.3.1](v0.3.0...v0.3.1) (2025-11-13) ### Bug Fixes * nil meta becomes empty struct in send message conversion ([#105](#105)) ([60d3fcb](60d3fcb)) * remove keep-alive messages ([#100](#100)) ([493e497](493e497)) * use UUIDv7 in type ID generators ([#102](#102)) ([3a809ea](3a809ea)), closes [#101](#101) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
fix #99
Although sending keep-alive messages is compliant with the SSE standard, we unfortunately have to remove this feature for now to maintain compatibility with the widely-used python-sdk.