Skip to content

fix(spec): update last_updated_after to be a timestamp#1288

Closed
yarolegovich wants to merge 3 commits intoa2aproject:mainfrom
yarolegovich:yarolegovich/list-tasks-timestamp
Closed

fix(spec): update last_updated_after to be a timestamp#1288
yarolegovich wants to merge 3 commits intoa2aproject:mainfrom
yarolegovich:yarolegovich/list-tasks-timestamp

Conversation

@yarolegovich
Copy link
Copy Markdown
Member

@yarolegovich yarolegovich commented Dec 8, 2025 •
edited
Loading

Update ListTasksRequest.last_updated_after to use google.protobuf.Timestamp for consistency with the rest of the protocol.

fixes #1287

@yarolegovich yarolegovich requested a review from a team as a code owner December 8, 2025 12:55
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Dec 8, 2025

Summary of Changes

Hello @yarolegovich, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the last_updated_after field in the ListTasksRequest by migrating its data type to google.protobuf.Timestamp. This change ensures consistency across the protocol's timestamp handling and clarifies the expected input format for this field, addressing issue #1287.

Highlights

  • Data Type Update: The last_updated_after field within the ListTasksRequest message has been updated from an int64 to a google.protobuf.Timestamp.
  • Documentation Clarity: The accompanying comment for last_updated_after was revised to specify that the timestamp should be in ISO 8601 format, aligning with the google.protobuf.Timestamp type.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the last_updated_after field in ListTasksRequest from int64 to google.protobuf.Timestamp for better consistency across the protocol. This is a good improvement. I've added one minor suggestion to enhance the comment for this field by including an example timestamp, which aligns with the documentation style used for other timestamp fields in the same file.

@holtskinner holtskinner changed the title fix: update last_updated_after to be a timestamp fix(spec): update last_updated_after to be a timestamp Dec 8, 2025
@holtskinner holtskinner added the TSC Review To be reviewed by the Technical Steering Committee label Dec 9, 2025
@github-project-automation github-project-automation bot moved this to Backlog in TSC Review Dec 9, 2025
holtskinner
holtskinner approved these changes Dec 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@holtskinner holtskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to make any fixes needed in the Documentation as well.

@yarolegovich
Copy link
Copy Markdown
Member Author

yarolegovich commented Dec 11, 2025 •
edited
Loading

Be sure to make any fixes needed in the Documentation as well.

Double-checked, couldn't find field references anywhere.

This was referenced Jan 13, 2026
Closed
Closed
@Tehsmash Tehsmash mentioned this pull request Jan 13, 2026
Merged
darrelmiller added a commit that referenced this pull request Jan 14, 2026
@Tehsmash @yarolegovich @darrelmiller
fix(spec)!: Fixes for the last_updated_after field (#1358)
0e204bf 
This PR combines two fixes for the ListTaskRequest last_updated_after
field one changes the field to a timestamp type and one renames it and
clarifies the ordering of the task list result.

Original PR for the timestamp type fix was:
#1288

Fixes: #1287
Fixes: #1206

---------

Co-authored-by: Yaroslav Shevchuk <yarolegovich@gmail.com>
Co-authored-by: Darrel <darrmi@microsoft.com>
@darrelmiller
Copy link
Copy Markdown
Contributor

darrelmiller commented Jan 30, 2026

This was addressed in #1358

@github-project-automation github-project-automation bot moved this from Backlog to Done in TSC Review Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holtskinner holtskinner holtskinner approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@yarolegovich yarolegovich

Labels

TSC Review To be reviewed by the Technical Steering Committee

Projects

TSC Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: ListTasksRequest incorrect timestamp type

3 participants

@yarolegovich @darrelmiller @holtskinner