fix: don't attempt to apply prettier if it is not available#1246
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the formatter would fail when prettier is not installed by adding graceful handling for missing prettier commands. The fix modifies the applyPrettier function to skip prettier formatting when it's not available (unless explicitly required) rather than failing entirely.
- Adds availability check for prettier command before attempting to use it
- Returns early with no error when prettier is unavailable and not required
- Improves error message to include the specific command when prettier is required but unavailable
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/format/templ.go | Modified applyPrettier function to check prettier availability and handle graceful fallback |
| internal/prettier/prettier_test.go | Added test coverage for the IsAvailable function with both positive and negative cases |
dgrundel
pushed a commit
to dgrundel/templ
that referenced
this pull request
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1244