fix: Update tag regex to also match emojis with variation selectors#6202
Merged
Conversation
Member
|
Looks good, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that even after the recent fix for emojis in tags (#6155), there were still some emojis that were not detected correctly when in tags, e.g. ☑️:
After a quick research, it turns out that some symbols have a dual representation: either a text-based, or a colorful (=emoji) one. This can be toggled with a special, invisible Unicode character, called variation selector. The selector has the encoding
U+FE0F. The checkmark symbol, in it's plain text form, has encodingU+2611. When the variation selector is added, the total encoding becomes\u2611\uFE0F, which then gets decoded as the emoji checkmark (☑️). Note that it may also be possible that the plain encoding itself could be decoded/rendered as the emoji directly (as it seems to be the case here on Github: when I copy the plain checkmark from this page, it is rendered in the PR description as the emoji checkmark).Changes
To fix the issue, we have to allow the variation selector in the regex. Also,
Emojiis a superset ofEmoji_Presentation, so I changed that as well, to cover more symbols.With the fix, the example tag from above is correctly parsed:
Additional information
Tested on: Windows 11, Ubuntu WSL