fix: Allow unicode emojis in tags#6155
Merged
Merged
Conversation
Member
|
Does this by any Chance also fix #6157? |
Collaborator
Author
Collaborator
Author
I just checked, and it indeed works again correctly with this fix. |
Member
|
Hah, that's what I suspected. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a recent issue that prevented having emojis in tags. If there was an emoji, the tag would not be parsed correctly.
Changes
Fixed the tag regex to allow unicode emojis. Also refactored the regex to use unicode property escapes.
Additional information
Tested on: WSL Ubuntu
Also closes: #6157