[Fix] Correct pathDirname output for root-level directories#6142
Merged
Conversation
Member
|
Ah gracias, and that should correctly give us back search for windows users who have a workspace at a volume root, correct? |
Collaborator
Author
|
I'm pretty confident it will, but I cannot confirm myself since I dont have a windows machine |
Member
|
That's what unit tests are for 😎 I'd argue we yolo it and then let users test a manual nightly! I'll merge in a few moments |
Collaborator
Author
|
couldnt agree more! |
benniekiss
added a commit
to benniekiss/Zettlr
that referenced
this pull request
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with
pathDirnamewhich was stripping the final path separator if the provided path was a root-level path, such asC:\Notesor/notes, which would be returned asC:or ``Closes #6105
Changes
A check was added to
pathDirnameto ensure the final path separator is not removed by first checking if the path is absolute and whether the first and last found path separator are at the same position.Two test cases were added which failed before the patches.
Additional information
I would appreciate verification on a windows platform if this fixes issues related to search. I do not have a windows machine.
Tested on: macOS 26