Skip to content

mb_strpos(): Empty delimiter #17

@GaryJones

Description

@GaryJones

This assertion:

self::assertStringContainsString( $options['apikey'], $registry['parsely-analytics-for-wordpress']['payload'] );

found in the test files of this PR (work in progress, so may change), gave a failure in a GitHub Action when run under PHP 5.6.40 and PHPUnit 5.7.27, with an error message of mb_strpos(): Empty delimiter.

It points to this part of this repo, which then appears to rely on PHPUnit itself (assertContains()).

The next PHP up in my workflow is PHP 7.0.33, and that uses PHPUnit 6.5.14, and that works fine.

This issue in PHPUnit seems highly relevant, so I think I'm looking for a back-compat fix for assertContains() for PHPUnit 5.7.

Could this be added in please @jrfnl?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions