Skip to content

AssertContains - handle empty string in string.#2778

Closed
SpacePossum wants to merge 1 commit into
sebastianbergmann:masterfrom
SpacePossum:master_contains_empty
Closed

AssertContains - handle empty string in string.#2778
SpacePossum wants to merge 1 commit into
sebastianbergmann:masterfrom
SpacePossum:master_contains_empty

Conversation

@SpacePossum

@SpacePossum SpacePossum commented Sep 19, 2017

Copy link
Copy Markdown
Contributor

closes #2520

This PR make the following assert pass:

$this->assertContains('', 'test');

previous:

There was 1 error:

1) myTest::testA
mb_strpos(): Empty delimiter

/home/possum/work/phpunit/src/Framework/Constraint/StringContains.php:59

localheinz
localheinz approved these changes Sep 19, 2017
View reviewed changes

@localheinz localheinz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SpacePossum SpacePossum force-pushed the master_contains_empty branch from 6631f70 to bbf4aee Compare October 4, 2017 07:59
@codecov-io

codecov-io commented Oct 4, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2778 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2778      +/-   ##
============================================
+ Coverage     54.84%   54.85%   +0.01%     
- Complexity     2794     2795       +1     
============================================
  Files           104      104              
  Lines          7766     7768       +2     
============================================
+ Hits           4259     4261       +2     
  Misses         3507     3507
Impacted Files Coverage Δ Complexity Δ
src/Framework/Constraint/StringContains.php 100% <100%> (ø) 6 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9396b6...bbf4aee. Read the comment docs.

@sebastianbergmann sebastianbergmann added the type/bug Something is broken label Oct 13, 2017
@sebastianbergmann

sebastianbergmann commented Oct 13, 2017

Copy link
Copy Markdown
Owner

Merged manually, thanks.

@SpacePossum SpacePossum deleted the master_contains_empty branch October 13, 2017 14:59
@jeherve jeherve mentioned this pull request May 7, 2020
Merged
@GaryJones GaryJones mentioned this pull request Jun 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@localheinz localheinz localheinz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/bug Something is broken

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mb_strpos(): Empty delimiter

4 participants

@SpacePossum @codecov-io @sebastianbergmann @localheinz