Claude finished @Yeraze's task —— View job

PR Review: feat(telemetry): wire up newer AirQualityMetrics fields

Tasks:

• Gather context
• Read changed files
• Analyze code quality, bugs, performance, security, test coverage
• Post review feedback

Overall Assessment

This is a clean, well-scoped PR that properly extends AirQualityMetrics support. The architecture is sound — adding entries to AIR_QUALITY_UNITS automatically wires up both serial and MQTT ingestion paths, which is elegant. Below are some observations.

Minor Issues

UnifiedTelemetryPage.tsx — Missing particles40um and pmVocIdx/pmNoxIdx units in TYPE_UNITS

src/pages/UnifiedTelemetryPage.tsx:186-193 adds labels for pm40Standard, particlesTps, formFormaldehyde, etc. in TYPE_LABELS, and units in TYPE_UNITS — but particles40um, pmVocIdx, and pmNoxIdx are missing from TYPE_UNITS:

// TYPE_UNITS in UnifiedTelemetryPage.tsx — these entries appear missing:
particles40um: '#/0.1L',  // present in AIR_QUALITY_UNITS but missing here
pmVocIdx: 'VOC',          // present in AIR_QUALITY_UNITS but missing here
pmNoxIdx: 'NOx',          // present in AIR_QUALITY_UNITS but missing here

The inferUnit() fallback at line 206–213 won't catch these (no matching pattern), so the fleet-overview card will show no unit for those three types. The telemetryKeys.ts CANONICAL_TELEMETRY_UNITS is the correct source of truth, but UnifiedTelemetryPage maintains its own parallel TYPE_UNITS map rather than importing the canonical one.

TelemetryChart.tsx — New labels not added to TELEMETRY_LABEL_KEYS

The new fields are added to TELEMETRY_LABELS (the fallback English map, line 160–169) but not to TELEMETRY_LABEL_KEYS (the i18n translation key map, line 58–79). This is consistent with how other air-quality fields are handled in this file (none of them have i18n keys either), so this is acceptable as-is — just worth noting for a future i18n pass.

Observations

INTEGER_TELEMETRY_TYPES comment is slightly misleading (TelemetryGraphs.tsx:38-40)

The comment says // particlesTps fields are floats and are intentionally NOT listed here but then only adds pm40Standard to the set. pm40Standard is a uint32 per the protobuf, so this is correct. However particles40um is already listed at line 36 (added alongside the existing particles25um, particles50um, etc.), so the comment focusing only on pm40Standard is slightly incomplete — it doesn't mention that particles40um was also added. Minor readability nit.

Test coverage is solid. telemetryKeys.test.ts correctly asserts the normalization path for particles_40um → particles40um (the key protobuf.js snake_case edge case). meshtasticManager.airQualityParticles.test.ts provides end-to-end coverage including zero-value storage (important for particle counters). No gaps found.

No security concerns. The changes are entirely UI label/unit mapping and test code, with no external input handling, auth changes, or raw SQL.

No DB migration needed — confirmed by the PR description. These fields were never stored before, so there's nothing to backfill.

Summary

One real gap to address: particles40um, pmVocIdx, and pmNoxIdx are missing from UnifiedTelemetryPage.tsx's TYPE_UNITS map, which means those three will display without units in the fleet telemetry overview. Everything else looks correct and well-tested.

Claude finished @Yeraze's task —— View job

PR Review: feat(telemetry): wire up newer AirQualityMetrics fields

Tasks:

• Gather context
• Read changed files
• Analyze code quality, bugs, performance, security, test coverage
• Post review feedback

Overall Assessment

This PR is clean and correct. The previous review's gap (missing particles40um, pmVocIdx, pmNoxIdx from UnifiedTelemetryPage.tsx's TYPE_UNITS) has been addressed in the latest push — all three are now present at lines 189, 202, and 203 with the correct units (#/0.1L, VOC, NOx).

What was verified

UnifiedTelemetryPage.tsx — gap is closed. TYPE_UNITS now has entries for all 11 new fields: pm40Standard, particles40um, particlesTps, formFormaldehyde, formHumidity, formTemperature, pmTemperature, pmHumidity, pmVocIdx, pmNoxIdx. Short labels in TYPE_LABELS are also correct (e.g. 'CH₂O' for formaldehyde, 'Part 4.0µm' for particles40um).

TelemetryGraphs.tsx — all 10 new fields have color assignments (lines 818–827). The INTEGER_TELEMETRY_TYPES correctly includes pm40Standard and particles40um (uint32 per proto) but excludes the float fields (particlesTps, formFormaldehyde, pmVocIdx, pmNoxIdx, etc.).

TelemetryChart.tsx — fallback English labels correct. The new fields are added to TELEMETRY_LABELS consistently with adjacent entries. The intentional omission from TELEMETRY_LABEL_KEYS (i18n map) is consistent with every other air-quality field — acceptable as-is.

telemetryKeys.ts — architecture is sound. Adding to AIR_QUALITY_UNITS automatically propagates to CANONICAL_TELEMETRY_UNITS (serial + MQTT unit lookup) and MQTT_KEY_MIGRATIONS (historical row rewrite). The snakeToCamel regex handles the particles_40um underscore-before-digit case correctly.

Tests — comprehensive. telemetryKeys.test.ts line 65 asserts the normalization path for all 11 new canonical units. meshtasticManager.airQualityParticles.test.ts line 92 provides end-to-end coverage of the three fields most at risk from the protobuf.js quirk.

Pre-existing minor inconsistencies (not introduced by this PR)

These were present before and are out of scope for this PR, but flagged for awareness:

• envCurrent unit mismatch — telemetryKeys.ts:48 stores 'A', UnifiedTelemetryPage.tsx:176 shows 'mA'. Confirmed pre-existing by mqttIngestion.test.ts:723 which asserts 'A'.
• lux unit mismatch — telemetryKeys.ts uses 'lux', UnifiedTelemetryPage.tsx uses 'lx'. Both are valid symbols; just inconsistent.

Security / Performance

No concerns. All changes are UI label/unit mapping and tests. No external input handling, auth, raw SQL, or performance-sensitive paths are touched.

The PR is ready to merge. The gap flagged in the prior review is resolved.

View job