Merged
Conversation
Added Slovak strings
Added Dutch strings
Added dutch translation
Added Dutch translation
Merge from origin
Add zh-tw strings
… allow empty toolbar title
Add ability to customize toolbar drawables, root background color and allow empty toolbar title
Add methods in UCrop for getting the image width + height
maxSdkVersion removed - needed for saving image to Downloads
Made cropCIMG static
add FR translation file
…agePermission M permissions removed: not mandatory
…utside, and then inside again would make the crop rect jump. Reset previous touch points.
Fix: In freestyle crop, where user tap inside of the crop rect then o…
When a square image is rotated by 90 (180, 270) degrees, it is not croped.
Feature: Add a new freestyle crop mode.
When a square image is rotated by 90 (180, 270) degrees, it is not croped.
…Translation Feature/german translation
Hotfix/GitHub issue
fix Markdown formatting
Conflicts: build.gradle gradle/wrapper/gradle-wrapper.properties sample/build.gradle ucrop/build.gradle ucrop/src/main/java/com/yalantis/ucrop/task/BitmapCropTask.java
PenzK
reviewed
Apr 5, 2018
| if (uri != null) { | ||
| try { | ||
| UCropView uCropView = findViewById(R.id.ucrop); | ||
| uCropView.getCropImageView().setImageUri(getIntent().getData(), null); |
| .getSystemService(Context.NOTIFICATION_SERVICE); | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { | ||
| int importance = NotificationManager.IMPORTANCE_LOW; | ||
| NotificationChannel mChannel = new NotificationChannel(CHANNEL_ID, getString(R.string.channel_name), importance); |
Contributor
There was a problem hiding this comment.
mChannel is not a field. I recommend to move creation of channel into separate method
| public static UCropFragment newInstance(Bundle uCrop, UCropFragmentCallback callback) { | ||
| UCropFragment fragment = new UCropFragment(); | ||
| fragment.setArguments(uCrop); | ||
| fragment.setCallback(callback); |
Contributor
There was a problem hiding this comment.
Remake setting callback via onAttach method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same for non native