add FR translation file#229
Conversation
| <resources> | ||
| <string name="ucrop_label_original">Original</string> | ||
| <string name="ucrop_label_edit_photo">Modifier la photo</string> | ||
| <string name="ucrop_menu_crop">Recarder</string> |
There was a problem hiding this comment.
Is it correct translation? Because Google translate doesn't know this word.
There was a problem hiding this comment.
Sorry I made I typo, I will fix this 😀
| @@ -0,0 +1,5 @@ | |||
| <resources> | |||
There was a problem hiding this comment.
It lack translation for two more strings - ucrop_error_input_data_is_absent and ucrop_mutate_exception_hint
There was a problem hiding this comment.
Yes, they are exception messages. It's not common to translate this kind of messages, because they're used for logging, not for showing to the user. Everything in the logcat is in english: having translated messages in the logs might be confusing. Also you can see that they're not translated in NL and SK.
I think these strings should not be externalized at all. They should be directly found in the source code.
|
It makes sense. Thank you. |
No description provided.