Skip to content

Update spatie/array-to-xml#4037

Merged
dgw merged 2 commits intomasterfrom
ozh-update-spatie
Dec 26, 2025
Merged

Update spatie/array-to-xml#4037
dgw merged 2 commits intomasterfrom
ozh-update-spatie

Conversation

@ozh
Copy link
Copy Markdown
Member

@ozh ozh commented Dec 23, 2025

composer require spatie/array-to-xml --ignore-platform-reqs to bypass aura/sql 6.0.0 requires php ^8.4 -> your php version (8.1; overridden via config.platform, actual: 8.4.5) does not satisfy that requirement

This lib was throwing PHP deprecations on tests with 8.4+

`composer require spatie/array-to-xml --ignore-platform-reqs` to bypass `aura/sql 6.0.0 requires php ^8.4 -> your php version (8.1; overridden via config.platform, actual: 8.4.5) does not satisfy that requirement`
@ozh ozh requested review from LeoColomb and dgw December 23, 2025 20:06
@ozh
Copy link
Copy Markdown
Member Author

ozh commented Dec 23, 2025

Merge #4036 first then review here

@ozh ozh changed the title Attempt at updating spatie/array-to-xml Update spatie/array-to-xml Dec 24, 2025
@dgw
Copy link
Copy Markdown
Member

dgw commented Dec 25, 2025

I saw that #4036 was supposed to come first, so I went there. Will update this branch so CI can re-run on the newer PHP versions, then hopefully find a moment to review this PR in the next couple days.

@dgw dgw self-assigned this Dec 25, 2025
Copy link
Copy Markdown
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff of the library itself doesn't look too intimidating, and I confirmed that the deprecation warning emitted during tests appears to be gone.

Composer no longer checking the platform (includes/vendor/composer/platform_check.php was removed) might make PHP version mismatches a bit less obvious to site admins? But I don't think it's actually important to have that check running during autoload.

@dgw dgw merged commit 83bb5b2 into master Dec 26, 2025
8 checks passed
@dgw dgw deleted the ozh-update-spatie branch December 26, 2025 23:37
@dgw dgw removed the request for review from LeoColomb December 26, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants