Merged
Conversation
Also, added concurrency settings to cancel in-progress runs, should be push on the PR while a workflow is already running
Maybe some day one will want to make a PR to a branch Also, add workflow_dispatch trigger to workflow (enable manual running, not sure why we'd need it but why not)
Member
Author
|
LGTM, ping @dgw & @LeoColomb |
Member
Author
|
(do we like, or need, |
This was referenced Dec 23, 2025
dgw
approved these changes
Dec 25, 2025
Member
dgw
left a comment
There was a problem hiding this comment.
Regarding --testdox I'm neutral. Human readable output is nice, I guess, but so is having the exact test name for easy ctrl-f in the source. 🤷♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Of course this will fail, I always manage to break those yml files