Conversation
Fixes #3975 I don't even understand how this was considered fixed at some point :)
|
WIP - do not merge. It fixes the view when you ask specifically for "more than 0 clicks", but breaks the view if you ask for something else without specifying number of clicks (PR 3589) |
|
👍 -- someone wants to approve this ? should I merge myself ? it's been so long :) |
dgw
left a comment
There was a problem hiding this comment.
It certainly is easier to read this way.
Having replaced this function on my instance (1.10.1) with the patch, it seems to work. "more" than 0 clicks correctly omits 0-click links, and an empty text box brings them back.
|
Let's give @LeoColomb a day or two in case he wants to weigh in, but I think it's good to go. |
LeoColomb
left a comment
There was a problem hiding this comment.
Despite a cosmetic suggestion, looks all good for me 👍
(I've seen the other discussions; I'll reply later this week. Too busy atm 😭)
Co-authored-by: Léo Colombaro <LeoColomb@users.noreply.github.com>
* Fix "show links with more than 0 clicks" Fixes YOURLS#3975 I don't even understand how this was considered fixed at some point :) * Fix : - searching for "more than 0 clicks" works - searching for something else doesn't enforce "more than 0 clicks" Really fixes YOURLS#3975 and YOURLS#3460 without one canceling the other, duh. * Update includes/Views/AdminParams.php Co-authored-by: Léo Colombaro <LeoColomb@users.noreply.github.com> --------- Co-authored-by: Léo Colombaro <LeoColomb@users.noreply.github.com>
Fixes #3975
I don't even understand how this was considered fixed at some point :)