Skip to content

Upgrade Aura.SQL to fix PHP 8.4 compatibility#3852

Merged
LeoColomb merged 13 commits intoYOURLS:masterfrom
AlexanderWillner:issue-3839
Mar 2, 2025
Merged

Upgrade Aura.SQL to fix PHP 8.4 compatibility#3852
LeoColomb merged 13 commits intoYOURLS:masterfrom
AlexanderWillner:issue-3839

Conversation

@AlexanderWillner
Copy link
Copy Markdown
Contributor

@AlexanderWillner AlexanderWillner commented Feb 9, 2025

This pull request addresses issue #3839

Fixes #3839
Closes #3827

Copy link
Copy Markdown
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this pull request, @AlexanderWillner.
Looks great overall, see my online comments for some tweaking.

Copy link
Copy Markdown
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your last edits @AlexanderWillner.
While your changes look good to me, I'm a bit triggered by the fact all previous PHP versions are simply dropped.
It feels like a giant step, somewhat too broad.
What do you think, @YOURLS/core?

@LeoColomb LeoColomb changed the title Upgrade to aura/sql:^6.0.0 to fix PHP 8.4 compatibility Upgrade Aura.SQL to fix PHP 8.4 compatibility Feb 18, 2025
@dgw
Copy link
Copy Markdown
Member

dgw commented Feb 18, 2025

What do you think, @YOURLS/core?

NAK, the software needs to support at minimum all currently-maintained PHP versions (right now, 8.1-8.4). Dropping everything older than 8.4 is a no-go, and CI coverage for the whole range also needs to be kept.

I'm fine with formally dropping 7.4 (last updated 26 months ago) and mostly fine with dropping 8.0 (last updated 14 months ago). My hosting company forcibly updated anyone still using 7.4, at least, some time ago. Any host that still has those dead versions around is encouraging bad practices, IMO. [PHP EOL]

@AlexanderWillner
Copy link
Copy Markdown
Contributor Author

AlexanderWillner commented Feb 19, 2025

I agree, it should work with PHP 8.0 / PHP 8.1 - currently https://github.com/auraphp/Aura.Sql/blob/8e2bb362e8953198df3682c9122e8b9edab5ff20/composer.json#L25 points to >= PHP 8.4 - not sure if this is really required.
It seems to be fixed to 8.4 on purpose: auraphp/Aura.Sql@92df922

Copy link
Copy Markdown
Contributor Author

@AlexanderWillner AlexanderWillner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, missed that

@srjlewis
Copy link
Copy Markdown

srjlewis commented Feb 25, 2025

Hi all

To chip in, I do run a fork of aura/sql that is a direct replacement, but is compatable with < 8.4 and replaces v5 and v6 of aura/sql which I use within projects I or my dev team work on.

srjlewis/aura-sql

I keep it as close to the origanal as posable but with the following changes auraphp/Aura.Sql@6.x...srjlewis:Aura.Sql:6.x

Please fill feel free to use it, and I can make any changes with in reason.

@LeoColomb
Copy link
Copy Markdown
Member

Thanks for the input @srjlewis.
Seeing the diffs are pretty little, is there a specific reason for them not to be included in main Aura.SQL?

@LeoColomb LeoColomb merged commit e1359e4 into YOURLS:master Mar 2, 2025
5 checks passed
@srjlewis
Copy link
Copy Markdown

srjlewis commented Mar 2, 2025

Thanks for the input @srjlewis. Seeing the diffs are pretty little, is there a specific reason for them not to be included in main Aura.SQL?

There was some large discussions about it, but they decided they only want to support PHP 8.4 and above, and not use my sugestions.

@dgw dgw mentioned this pull request Mar 3, 2025
2 tasks
tomtenuta pushed a commit to tomtenuta/YOURLS that referenced this pull request Nov 4, 2025
Co-authored-by: Léo Colombaro <LeoColomb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP 8.4 not supported

4 participants