Upgrade Aura.SQL to fix PHP 8.4 compatibility#3852
Conversation
LeoColomb
left a comment
There was a problem hiding this comment.
Thanks for submitting this pull request, @AlexanderWillner.
Looks great overall, see my online comments for some tweaking.
Co-authored-by: Léo Colombaro <LeoColomb@users.noreply.github.com>
LeoColomb
left a comment
There was a problem hiding this comment.
Thanks for your last edits @AlexanderWillner.
While your changes look good to me, I'm a bit triggered by the fact all previous PHP versions are simply dropped.
It feels like a giant step, somewhat too broad.
What do you think, @YOURLS/core?
NAK, the software needs to support at minimum all currently-maintained PHP versions (right now, 8.1-8.4). Dropping everything older than 8.4 is a no-go, and CI coverage for the whole range also needs to be kept. I'm fine with formally dropping 7.4 (last updated 26 months ago) and mostly fine with dropping 8.0 (last updated 14 months ago). My hosting company forcibly updated anyone still using 7.4, at least, some time ago. Any host that still has those dead versions around is encouraging bad practices, IMO. [PHP EOL] |
|
I agree, it should work with PHP 8.0 / PHP 8.1 - currently https://github.com/auraphp/Aura.Sql/blob/8e2bb362e8953198df3682c9122e8b9edab5ff20/composer.json#L25 points to >= PHP 8.4 - not sure if this is really required. |
AlexanderWillner
left a comment
There was a problem hiding this comment.
thanks, missed that
|
Hi all To chip in, I do run a fork of aura/sql that is a direct replacement, but is compatable with < 8.4 and replaces v5 and v6 of aura/sql which I use within projects I or my dev team work on. I keep it as close to the origanal as posable but with the following changes auraphp/Aura.Sql@6.x...srjlewis:Aura.Sql:6.x Please fill feel free to use it, and I can make any changes with in reason. |
|
Thanks for the input @srjlewis. |
There was some large discussions about it, but they decided they only want to support PHP 8.4 and above, and not use my sugestions. |
Co-authored-by: Léo Colombaro <LeoColomb@users.noreply.github.com>
This pull request addresses issue #3839
Fixes #3839
Closes #3827