Skip to content

Ensure all statusCode/errorCode API values are strings#3756

Merged
ozh merged 1 commit intoYOURLS:masterfrom
dgw:consistent-statusCode
May 8, 2024
Merged

Ensure all statusCode/errorCode API values are strings#3756
ozh merged 1 commit intoYOURLS:masterfrom
dgw:consistent-statusCode

Conversation

@dgw
Copy link
Copy Markdown
Member

@dgw dgw commented May 7, 2024

PHPDoc comments about the API response format say that both statusCode and errorCode are expected to be strings, but a lot of cases were returning ints instead. This could cause problems for JSON clients.

This should resolve #3755.

PHPDoc comments about the API response format say that both `statusCode`
and `errorCode` are expected to be strings, but a lot of cases were
returning ints instead. This could cause problems for JSON clients.
Copy link
Copy Markdown
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable 👍

@ozh ozh merged commit 469763c into YOURLS:master May 8, 2024
@dgw dgw deleted the consistent-statusCode branch July 6, 2024 22:59
tomtenuta pushed a commit to tomtenuta/YOURLS that referenced this pull request Nov 4, 2025
PHPDoc comments about the API response format say that both `statusCode`
and `errorCode` are expected to be strings, but a lot of cases were
returning ints instead. This could cause problems for JSON clients.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent data type of statusCode in API response

3 participants