Fix results with 0 clicks on search#3589
Merged
ozh merged 1 commit intoYOURLS:masterfrom Jul 15, 2023
JensSpanier:no-result-on-search
Merged
Fix results with 0 clicks on search#3589ozh merged 1 commit intoYOURLS:masterfrom JensSpanier:no-result-on-search
ozh merged 1 commit intoYOURLS:masterfrom
JensSpanier:no-result-on-search
Conversation
Member
|
Thanks ! |
Closed
5 tasks
tomtenuta
pushed a commit
to tomtenuta/YOURLS
that referenced
this pull request
Nov 4, 2025
Check if `click_limit` is empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a bug where the search result doesn't return entries whith 0 clicks.
When using the search on the admin page,
$_GET['click_limit']is alwas set. It's just empty. So I check for!emptyinstead ofisset.It's also a possible fix to remove
=from the checkintval($_GET['click_limit']) >= 0.Let me know what you think about this.