Conversation
This all boils down to redirecting to $_SERVER['REQUEST_URI'] after successful login
This was referenced Mar 22, 2020
LeoColomb
requested changes
Mar 23, 2020
Member
LeoColomb
left a comment
There was a problem hiding this comment.
Few comments 😄
Otherwise lgtm 👍
- no dying - no output if we're on cli
Co-Authored-By: Léo Colombaro <git@colombaro.fr>
Co-Authored-By: Léo Colombaro <git@colombaro.fr>
Do not rely on HOSTNAME, HTTP_HOST or whatever, just use YOURLS_SITE
Contributor
|
@ozh I've tested this on our Docker installation and it fixes the issues I was encountering. Thank you. |
[skip ci] [skip scrutinizer]
Member
Author
|
Merging. Thanks @hangxingliu and @pcolmer for insightful feedbacks which has led to this PR |
tomtenuta
pushed a commit
to tomtenuta/YOURLS
that referenced
this pull request
Nov 4, 2025
* Attempt at fixing YOURLS#2603 and superseding YOURLS#2545 This all boils down to redirecting to $_SERVER['REQUEST_URI'] after successful login Thanks @hangxingliu and @pcolmer for insightful feedbacks which has led to this PR * Refactor slightly the redirect function - no dying - no output if we're on cli * Update tests/includes/utils.php Co-Authored-By: Léo Colombaro <git@colombaro.fr> * Update includes/functions.php Co-Authored-By: Léo Colombaro <git@colombaro.fr> * Rewrite yourls_get_request() Do not rely on HOSTNAME, HTTP_HOST or whatever, just use YOURLS_SITE * Remove leftover comment [skip ci] [skip scrutinizer] Co-authored-by: Léo Colombaro <git@colombaro.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This all boils down to redirecting to $_SERVER['REQUEST_URI'] after successful login and using less $_SERVER variables ('HTTP_HOST', 'HOSTNAME', 'SERVERNAME' or whatnot)