Closed
Conversation
Xuanwo
reviewed
Nov 30, 2024
| pub use exponential::ExponentialBuilder; | ||
|
|
||
| #[cfg(feature = "std")] | ||
| fn f32() -> f32 { |
Owner
There was a problem hiding this comment.
Thanks a lot for your PR! I suggest we split this PR into two:
- One is to make sure backon available on
std - The other one is to add
embassy_timesupport.
|
|
||
| #[cfg(all(not(feature = "std"), not(feature = "embassy-time")))] | ||
| fn f32() -> f32 { | ||
| fastrand::Rng::with_seed(0x2fdb0020ffc7722b).f32() |
Owner
There was a problem hiding this comment.
How about adding a seed option on ExponentialBuilder instead? In this way, we can avoid unexpected behavior happened.
We can't carry an Rng in builder since it doesn't copy.
Contributor
Author
There was a problem hiding this comment.
Sounds good to me.
Xuanwo
added a commit
that referenced
this pull request
Dec 17, 2024
Split #168 into two PRs as requested, this is the one for no_std support. --------- Co-authored-by: Xuanwo <github@xuanwo.io>
wackazong
added a commit
to wackazong/backon
that referenced
this pull request
Dec 17, 2024
Split Xuanwo#168 into two PRs as requested, this is the one for no_std support. --------- Co-authored-by: Xuanwo <github@xuanwo.io>
wackazong
added a commit
to wackazong/backon
that referenced
this pull request
Dec 17, 2024
Split Xuanwo#168 into two PRs as requested, this is the one for no_std support. --------- Co-authored-by: Xuanwo <github@xuanwo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a sleeper based on the embassy framework in no_std. Also did some adjustments to fastrand since the current no_std implementation did not compile. fastrand supports no_std, but only without a global RNG.