Commands: x25519 outputs "Password" -> "Password (PublicKey)"#5759
Merged
Commands: x25519 outputs "Password" -> "Password (PublicKey)"#5759
x25519 outputs "Password" -> "Password (PublicKey)"#5759Conversation
Updated output message to clarify password usage as public key.
Member
|
我想过这么做 但是怎么写都拿不准 一个办法是拆成两个命令 一个给vless输出passwd一个给wireguard生成公私钥对 还有一个办法是这个命令独立生成两对密钥对 一个写passwd一个写public key 但是始终无法在反映本质/提醒用户安全 间取得一个合理的输出（前面的方法在知情者眼中比较蠢） |
Member
|
|
Member
|
改成了只加个 |
x25519 Password -> Password (PublicKey)
x25519 Password -> Password (PublicKey)x25519 outputs Password -> Password (PublicKey)
Member
|
#5160 (comment) 这里说的叫 ClientKey 其实也行，不过还是和 ML-KEM-768 区分一下吧， |
Member
|
|
RPRX
added a commit
that referenced
this pull request
Mar 19, 2026
#5084 (comment) #5123 (comment) ... --------- Co-authored-by: RPRX <63339210+RPRX@users.noreply.github.com>
x25519 outputs Password -> Password (PublicKey)x25519 outputs "Password" -> "Password (PublicKey)"
RPRX
added a commit
that referenced
this pull request
Mar 19, 2026
#5084 (comment) #5123 (comment) ... --------- Co-authored-by: RPRX <63339210+RPRX@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
As a developer, when you see a PrivateKey, the mental model immediately looks for a corresponding PublicKey. In the current x25519 command output, the PublicKey is labeled as Password. While this was intentionally done to discourage users from sharing it publicly (as seen in this #5084 ), it creates significant friction and confusion for new users.
I personally experienced this confusion, spending considerable time cross-referencing documentation and discussions to realize that Password is indeed the pbk parameter required for Reality/VLESS configurations.
The Solution
This PR updates the output labels to provide immediate clarity without compromising the original security intent. By explicitly labeling it as Password (Public key/pbk), we:
1- Reduce Cognitive Load: Users no longer need to guess which field maps to the pbk in their client config.
2- Maintain Security Awareness: A supplementary note is added to explain why this key should be treated with care, addressing the maintainers' original concern about public exposure.
Changes
Updated fmt.Printf labels in main/commands/all/curve25519.go.
Added a one-liner instructional note to explain the usage and security of the key.