Skip to content

Truncating thread name on linux#5758

Merged
bthomee merged 2 commits intoXRPLF:developfrom
janibakin:janibakin/thread-name-linux
Jan 9, 2026
Merged

Truncating thread name on linux#5758
bthomee merged 2 commits intoXRPLF:developfrom
janibakin:janibakin/thread-name-linux

Conversation

@janibakin
Copy link
Copy Markdown
Contributor

@janibakin janibakin commented Sep 3, 2025

High Level Overview of Change

  • Truncate/shorten long thread names on Linux to 15 chars as per limit.
  • Warn/notify developer/user about the truncation in stderr. By default, notification is ON in Debug mode, OFF in Release.
    Can be overwritten with -DTRUNCATED_THREAD_NAME_LOGS=ON/OFF during cmake configure.

Context of Change

Fixing 5691.
The setCurrentThreadName function does not warn or fail when provided with a string that is too long for the target platform. This results in the name being silently truncated by the operating system, which can make debugging difficult.

For example, on Linux, the thread name is limited to 15 characters (the underlying TASK_COMM_LEN is 16 bytes, including the null terminator). Passing a longer string should ideally trigger an assertion in debug builds or be handled in a way that notifies the developer.

Furthermore, given that in most rippled use cases we pass constant string literals, this check can also be performed at compile time to catch errors even earlier in the development process.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@janibakin janibakin force-pushed the janibakin/thread-name-linux branch from 9ce45bb to 7025b5e Compare September 17, 2025 16:39
@janibakin janibakin marked this pull request as ready for review September 17, 2025 16:40
@bthomee bthomee requested a review from vlntb September 24, 2025 06:43
@bthomee bthomee changed the title Janibakin: Truncating thread name on linux Truncating thread name on linux Oct 3, 2025
@Tapanito Tapanito added the Triaged Issue/PR has been triaged for viability, liveliness, etc. label Oct 3, 2025
@bthomee bthomee added this to the 3.1.0 milestone Oct 3, 2025
@Tapanito Tapanito requested a review from a1q123456 October 3, 2025 15:23
constexpr std::size_t linuxThreadNameMaxLen = 15;

#ifdef TRUNCATED_THREAD_NAME_LOGS
thread_local std::unordered_set<std::string> loggedLongThreadNames_;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is overkill to keep the original long thread names.
It is enough to log an error or a warning and truncate.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, will update.

#include <xrpl/beast/core/CurrentThreadName.h>
#include <xrpl/beast/unit_test.h>

#include <boost/predef/os/linux.h>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this test fail on macOS and Windows?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably should not. I see #include <boost/predef.h> is used in CurrentThreadName.cpp, and <boost/predef/os/linux.h> is included inside <boost/predef.h>. But I'll double check and try compiling on mac and windows

Copy link
Copy Markdown
Contributor

@vlntb vlntb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, rippled runs on three OS families: Linux, macOS, and Windows. This change only addresses thread naming on Linux. What’s the plan for macOS and Windows?

@janibakin janibakin force-pushed the janibakin/thread-name-linux branch 3 times, most recently from 4ed462a to edc35d3 Compare November 1, 2025 23:07
@janibakin
Copy link
Copy Markdown
Contributor Author

janibakin commented Nov 1, 2025

Made some changed as suggested. Please have a look. Just so you know, I managed to build and test this in all Linux, Windows and MacOs.

I think I still need to add support for Windows and MacOs. I only recently realised this needs to be done not only for Linux...

@a1q123456
Copy link
Copy Markdown
Contributor

Made some changed as suggested. Please have a look. Just so you know, I managed to build and test this in all Linux, Windows and MacOs.

I think I still need to add support for Windows and MacOs. I only recently realised this needs to be done not only for Linux...

I don't think macos and windows enforce a length limit on thread names so we only have to make sure the logic only applies to linux, the code looks good otherwise.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.1%. Comparing base (c24a604) to head (9875ff3).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5758   +/-   ##
=======================================
  Coverage     79.1%   79.1%           
=======================================
  Files          836     837    +1     
  Lines        71261   71269    +8     
  Branches      8304    8302    -2     
=======================================
+ Hits         56392   56402   +10     
+ Misses       14869   14867    -2     
Files with missing lines Coverage Δ
include/xrpl/beast/core/CurrentThreadName.h 100.0% <100.0%> (ø)
src/libxrpl/beast/core/CurrentThreadName.cpp 100.0% <100.0%> (ø)
src/libxrpl/resource/ResourceManager.cpp 75.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1q123456
Copy link
Copy Markdown
Contributor

Seems that we've got some build errors. Please could you run the pre-commit script and resolve the conflicts in RippledSettings.cmake when you have a chance? Thank you!

@bthomee
Copy link
Copy Markdown
Collaborator

bthomee commented Nov 21, 2025

@janibakin would you be able to resolve the conflicts & use the pre-commit hooks to format the code?

@janibakin
Copy link
Copy Markdown
Contributor Author

@bthomee Hi, sure, will do. I'm quite busy, but I'll come to this during the weekend hopefully.

* truncate thread names if more than 15 chars with snprintf
* add warnings for truncated thread names: -DTRUNCATED_THREAD_NAME_LOGS=ON/OFF
* add static assert for string literals to stop compiling if > 15 chars
* reduce Resource::Manager to Resource::Mngr to fix static assert failure
* update CurrentThreadName_test unit test specifically for Linux to verify truncation
@janibakin janibakin force-pushed the janibakin/thread-name-linux branch from edc35d3 to 9002d3d Compare November 24, 2025 21:36
@janibakin
Copy link
Copy Markdown
Contributor Author

@bthomee done, rebased and run pre-commit hooks to format.

@a1q123456 a1q123456 requested a review from vlntb November 25, 2025 14:24
@vvysokikh1 vvysokikh1 added the Needs additional review PR requires at least one more code review approval before it can be merged label Nov 28, 2025
Copy link
Copy Markdown
Contributor

@vlntb vlntb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — this addresses #5691 on Linux (compile-time check for string literals + runtime truncation). Tests look good. Thanks, @janibakin !

@bthomee
Copy link
Copy Markdown
Collaborator

bthomee commented Jan 9, 2026

@janibakin is this change ready to be merged?

@janibakin
Copy link
Copy Markdown
Contributor Author

@bthomee yes, you can merge

@bthomee bthomee added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. and removed Needs additional review PR requires at least one more code review approval before it can be merged Triaged Issue/PR has been triaged for viability, liveliness, etc. labels Jan 9, 2026
@bthomee bthomee merged commit fc00723 into XRPLF:develop Jan 9, 2026
25 checks passed
mvadari pushed a commit to mvadari/rippled that referenced this pull request Jan 9, 2026
This change:
* Truncates thread names if more than 15 chars with `snprintf`.
* Adds warnings for truncated thread names if `-DTRUNCATED_THREAD_NAME_LOGS=ON`.
* Add a static assert for string literals to stop compiling if > 15 chars.
* Shortens `Resource::Manager` to `Resource::Mngr` to fix the static assert failure.
* Updates `CurrentThreadName_test` unit test specifically for Linux to verify truncation.
pratikmankawde added a commit that referenced this pull request Jan 21, 2026
refactor: Update Conan dependencies: protobuf and grpc (#5589)

This PR updates protobuf and grpc to their latest versions. The latest protobuf version no longer requires patches, so we can use it directly from the official Conan Center Index, while the latest grpc still needed a patch, which was added to our own Conan Center Index fork in XRPLF/conan-center-index#8.

cleanup

docs: Infer version of Conan dependency to export (#6112)

This change updates a script in the documentation to automatically infer the version of a patched Conan dependency from the conan.lock file.

chore: Use updated secp256k1 recipe (#6118)

This change updates the secp256k1 recipe that defines the SECP256K1_STATIC, so it no longer needs to be defined in the code here. Running the Conan update script also updated two other recipes in the lock file.

chore: Clean up .gitignore and .gitattributes (#6001)

The .gitignore and .gitattributes files contain references to files and directories that the current build no longer produces, so this change removes obsolete entries in these files, and does some general reorganizing of the remaining entries.

chore: Fix docs readme and cmake (#6122)

This change removes the unused `with_docs` option and fixes the README instructions on how to build the `docs` target.

removed amendment changes

added limit to reply size

Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>

minor clean-up

Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>

refactor: clean up `RPCHelpers` (#5684)

This PR cleans up `RPCHelpers.h` and `RPCHelpers.cpp`. It splits out all the fetch-ledger functions to a new set of files, `RPCLedgerHelpers.h`/`RPCLedgerHelpers.cpp`, and moves the general-API functions to `ApiVersion.h`. There is no functionality change.

refactor: rename `LedgerInfo` to `LedgerHeader` (#6136)

This PR renames `LedgerInfo` to `LedgerHeader`. Namely, `LedgerInfo` was already an alias for `LedgerHeader`, and the comments next to the alias suggested that it would make sense to rename it, since that makes it clearer what it is.

refactor: rename info() to header() (#6138)

This change renames all the `info()` functions to `header()`, since they return `LedgerHeader` structs. It also renames the underlying variables from `info_` to `header_`.

refactor: Rename `rippled` binary to `xrpld` (#5983)

Per [XLS-0095](https://xls.xrpl.org/xls/XLS-0095-rename-rippled-to-xrpld.html), we are taking steps to rename ripple(d) to xrpl(d).

This change modifies the binary name from `rippled` to `xrpld`, and creates a symlink named `rippled` that points to the `xrpld` binary.

Note that #5975 renamed any references to `rippled` in the CMake files and their contents, but explicitly maintained the `rippled` binary name by adding an exception. This change now undoes this exception and adds an explicit symlink instead.

subscription test was failing, so trying with longer timeout,

Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>

Update src/xrpld/overlay/detail/PeerImp.cpp

update comparison operator.

Co-authored-by: Ed Hennis <ed@ripple.com>

Update src/xrpld/overlay/detail/PeerImp.cpp

combine strings

Co-authored-by: Ed Hennis <ed@ripple.com>

refactor: Move JobQueue and related classes into xrpl.core module (#6121)

refactor: Rename `ripple` namespace to `xrpl` (#5982)

This change renames all occurrences of `namespace ripple` and `ripple::` to `namespace xrpl` and `xrpl::`, respectively, as well as the names of test suites. It also provides a script to allow developers to replicate the changes in their local branch or fork to avoid conflicts.

chore: Fix some typos in comments (#6082)

ci: Update shared actions (#6147)

The latest update to `cleanup-workspace`, `get-nproc`, and `prepare-runner` moved the action to the repository root directory, and also includes some ccache changes. In response, this change updates the various shared actions to the latest commit hash.

refactor: remove `Json::Object` and related files/classes (#5894)

`Json::Object` and related objects are not used at all, so this change removes `include/xrpl/json/Object.h` and all downstream files. There are a number of minor downstream changes as well.

Full list of deleted classes and functions:
* `Json::Collections`
* `Json::Object`
* `Json::Array`
* `Json::WriterObject`
* `Json::setArray`
* `Json::addObject`
* `Json::appendArray`
* `Json::appendObject`

The last helper function, `copyFrom`, seemed a bit more complex and was actually used in a few places, so it was moved to `LedgerToJson.h` instead of deleting it.

Set version to 3.2.0-b0 (#6153)

ci: Remove superfluous build directory creation (#6159)

This change modifies the build directory structure from `build/build/xxx` or `.build/build/xxx` to just `build/xxx`. Namely, the `conanfile.py` has the CMake generators build directory hardcoded to `build/generators`. We may as well leverage the top-level build directory without introducing another layer of directory nesting.

fix: Remove cryptographic libs from libxrpl Conan package (#6163)

* fix: rm crypto libs and fix protobuf path

* update/rm comments

chore: Pin ruamel.yaml<0.19 in pre-commit-hooks (#6166)

See pre-commit/pre-commit-hooks#1229 for more details.

Revert "chore: Pin ruamel.yaml<0.19 in pre-commit-hooks (#6166)" (#6167)

This reverts commit 0f23ad8.

refactor: Rename `rippled.cfg` to `xrpld.cfg` (#6098)

This change renames all occurrences of `rippled.cfg` to `xrpld.cfg`. It also provides a script to allow developers to replicate the changes in their local branch or fork to avoid conflicts. For the time being it maintains support for `rippled.cfg` as config file, if `xrpld.cfg` does not exist.

test: add more tests for `ledger_entry` RPC (#5858)

This change adds some basic tests for all the `ledger_entry` helper functions, so each ledger entry type is covered. There are further some minor refactors in `parseAMM` to provide better error messages. Finally, to improve readability, alphabetization was applied in the helper functions.

ci: Use ccache to cache build objects for speeding up building (#6104)

Right now, each pipeline invocation builds the source code from scratch. Although compiled Conan dependencies are cached in a remote server, the source build objects are not. We are able to further speed up our builds by leveraging `ccache`. This change enables caching of build objects using `ccache` on Linux, macOS, and Windows.

ci: Move variable into right place (#6179)

This change moves the `enable_ccache` variable in the `on-trigger.yml` file to the correct location.

refactor: Fix typos in comments, configure cspell (#6164)

This change sets up a `cspell `configuration and fixes lots of typos in comments. There are no other code changes.

refactor: Fix spelling issues in private/local variables and functions (#6182)

This change fixes several typos in private/local variables and private functions. There is no functionality change.

refactor: Fix spelling issues in all variables/functions (#6184)

This change fixes many typos in comments, variables, and public functions. There is no functionality change.

refactor: Remove unused credentials signature hash prefix (#6186)

This change removes the unused credentials signature hash prefix from `HashPrefix.h`.

fix: Reorder Batch Preflight Errors (#6176)

This change fixes #6058.

refactor: Fix typos, enable cspell pre-commit (#5719)

This change fixes the last of the spelling issues, and enables the pre-commit (and CI) check for spelling. There are no functionality changes, but it does rename some enum values.

ci: Use updated prepare-runner in actions and worfklows (#6188)

This change updates the XRPLF pre-commit workflow and prepare-runner action to their latest versions. For naming consistency the prepare-runner action changed the disable_ccache variable into enable_ccache, which matches our naming.

docs: Fix minor spelling issues in comments (#6194)

fix: Truncate thread name to 15 chars on Linux (#5758)

This change:
* Truncates thread names if more than 15 chars with `snprintf`.
* Adds warnings for truncated thread names if `-DTRUNCATED_THREAD_NAME_LOGS=ON`.
* Add a static assert for string literals to stop compiling if > 15 chars.
* Shortens `Resource::Manager` to `Resource::Mngr` to fix the static assert failure.
* Updates `CurrentThreadName_test` unit test specifically for Linux to verify truncation.

VaultClawback: Burn shares of an empty vault (#6120)

- Adds a mechanism for the vault owner to burn user shares when the vault is stuck. If the Vault has 0 AssetsAvailable and Total, the owner may submit a VaultClawback to reclaim the worthless fees, and thus allow the Vault to be deleted. The Amount must be left off (unless the owner is the asset issuer), specified as 0 Shares, or specified as the number of Shares held.

chore: Change `/Zi` to `/Z7` for ccache, remove debug symbols in CI (#6198)

As the `/Zi` compiler flag is unsupported by ccache, this change switches it to `/Z7` instead. For CI runs all debug info is omitted.

fix: Inner batch transactions never have valid signatures (#6069)

- Introduces amendment `fixBatchInnerSigs`
- Update Batch unit tests
  - Fix all the Env instantiations to _use_ the "features" parameter.
  - testInnerSubmitRPC runs with Batch enabled and disabled.
  - Add a test to testInnerSubmitRPC for a correctly signed tx incorrectly
    using the tfInnerBatchTxn flag.
  - Generalize the submitAndValidate lambda in testInnerSubmitRPC.
  - With the fix amendment, a transaction never reaches the transaction
    engine (Transactor and derived classes.)
  - Test submitting a pseudo-transaction. Stopped before reaching the
    transaction engine, but with different errors.
- The tests verify that without the amendment, a transaction with
  tfInnerBatchTxn is immediately rejected. Without the amendment, things
  are safe. The amendment just makes things safer and more future-proof.

chore: Pin pre-commit hooks to commit hashes (#6205)

This change updates and pins the Black and CSpell pre-commit hooks.

refactor: Remove unnecessary version number and options in cmake find_package (#6169)

This change removes unnecessary version numbers in the OpenSSL and Boost `find_package` CMake statements. An unnecessary OpenSSL definition is removed, while Conan options for SSL are updated to disable insecure ciphers. Moreover, the statements are now ordered alphabetically and more logically.

ci: Update actions/images to use cmake 4.2.1 and conan 2.24.0 (#6209)

fix: Update Conan lock file with changed OpenSSL recipe (#6211)

This change updates the `conan.lock` file with a changed OpenSSL recipe that contains a fix regarding options passed to the compiler

Improve and fix bugs in Lending Protocol (#6102)

- Spec: XLS-66

    Fix overpayment asserts (#6084)

    MPTTester::operator() parameter should be std::int64_t
    - Originally defined as uint64_t, but the testIssuerLoan() test called
      it with a negative number, causing an overflow to a very large number
      that in some circumstances could be silently cast back to an int64_t,
      but might not be. I believe this is UB, and we don't want to rely on
      that.

    Review feedback from @Tapanito: overpayment value change
    - In overpayment results, the management fee was being calculated twice:
      once as part of the value change, and as part of the fees paid.
      Exclude it from the value change.

    Fix Overpayment Calculation  (#6087)
    - Adds additional unit tests to cover math calculations.
    - Removes unused methods.

    Review feedback from @shawnxie999: even more rounding
    - Round the initial total value computation upward, unless there is
      0-interest.
    - Rename getVaultScale to getAssetsTotalScale, and convert one incorrect
      computation to use it.
    - Use adjustImpreciseNumber for LossUnrealized.
    - Add some logging to computeLoanProperties.

    Fix LoanBrokerSet debtMaximum limits (#6116)

    Fix some minor bugs in Lending Protocol (#6101)
    - add nodiscard to unimpairLoan, and check result in LoanPay
    - add a check to verify that issuer exists
    - improve LoanManage error code for dust amounts

    Check permissions in LoanSet and LoanPay (#6108)

    Disallow pseudo accounts to be Destination for LoanBrokerCoverWithdraw (#6106)

    Ensure vault asset cap is not exceeded (#6124)

    Fix Overpayment ValueChange calculation in Lending Protocol (#6114)
    - Adds loan state to LoanProperties.
    - Cleans up computeLoanProperties.
    - Fixes missing management fee from overpayment.

    fix: Enable LP Deposits when the broker is the asset issuer (#6119)
    * Replace accountHolds with accountSpendable when checking
    for account funds in VaultDeposit and LoanBrokerCoverDeposit

    Add a few minor changes (#6158)
    - Updates or fixes a couple of things I noticed while reviewing changes
      to the spec.
    - Rename sfPreviousPaymentDate to sfPreviousPaymentDueDate.
    - Make the vault asset cap check added in #6124 a little more robust:
      1. Check in preflight if the vault is _already_ over the limit.
      2. Prevent overflow when checking with the loan value. (Subtract
         instead of adding, in case the values are near maxint. Both return
         the same result. Also add a unit test so each case is covered.

    Add minimum grace period validation (#6133)

    Fix bugs: frozen pseudo-account, and FLC cutoff (#6170)

    refactor: Rename raw state to theoretical state (#6187)

    Check if a withdrawal amount exceeds any applicable receiving limit. (#6117)

    Fix overpayment result calculation (#6195)

    Address review feedback from Lending Protocol re-review (#6161)

---------

Co-authored-by: Gregory Tsipenyuk <gregtatcam@users.noreply.github.com>
Co-authored-by: Bronek Kozicki <brok@incorrekt.com>
Co-authored-by: Vito Tumas <5780819+Tapanito@users.noreply.github.com>
Co-authored-by: Shawn Xie <35279399+shawnxie999@users.noreply.github.com>
Co-authored-by: Jingchen <a1q123456@users.noreply.github.com>

Expand Number to support the full integer range (#6025)

- Refactor Number internals away from int64 to uint64 & a sign flag
  - ctors and accessors use `rep`. Very few things expose
    `internalrep`.
  - An exception is "unchecked" and the new "normalized", which explicitly
    take an internalrep. But with those special control flags, it's easier
    to distinguish and control when they are used.

- For now, skip the larger mantissas in AMM transactions and tests

- Remove trailing zeros from scientific notation Number strings
  - Update tests. This has the happy side effect of making some of the string
    representations _more_ consistent between the small and large
    mantissa ranges.

- Add semi-automatic rounding of STNumbers based on Asset types
  - Create a new SField metadata enum, sMD_NeedsAsset, which indicates
    the field should be associated with an Asset so it can be rounded.
  - Add a new STTakesAsset intermediate class to handle the Asset
    association to a derived ST class. Currently only used in STNumber,
    but could be used by other types in the future.
  - Add "associateAsset" which takes an SLE and an Asset, finds the
    sMD_NeedsAsset fields, and associates the Asset to them. In the case
    of STNumber, that both stores the Asset, and rounds the value
    immediately.
  - Transactors only need to add a call to associateAsset _after_ all of
    the STNumbers have been set. Unfortunately, the inner workings of
    STObject do not do the association correctly with uninitialized
    fields.
  - When serializing an STNumber that has an Asset, round it before
    serializing.
  - Add an override of roundToAsset, which rounds a Number value in place
    to an Asset, but without any additional scale.
  - Update and fix a bunch of Loan-related tests to accommodate the
    expanded Number class.

---------

Co-authored-by: Vito <5780819+Tapanito@users.noreply.github.com>

Change LendingProtocol feature and dependencies to supported (#6146)

minor code review changes

Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>

test: Replace `failed` string in Vault test case (#6214)

The word `failed` in the test case makes it hard to search through the test logs when an actual test failure occurs, so this change renames the word to just `fail` instead.

test: Suppress "parse failed" message in Batch tests (#6207)

test: Use gtest instead of doctest (#6216)

This change switches over the doctest framework to the gtest framework.

ci: Add sanitizers to CI builds (#5996)

This change adds support for sanitizer build options in CI builds workflow. Currently `asan+ubsan` is enabled, while `tsan+ubsan` is left disabled as more changes are required.

added unit test

Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>

updated levelization

Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>

Improve ledger_entry lookups for fee, amendments, NUNL, and hashes (#5644)

These "fixed location" objects can be found in multiple ways:

1. The lookup parameters use the same format as other ledger objects, but the only valid value is true or the valid index of the object:
  - Amendments: "amendments" : true
  - FeeSettings: "fee" : true
  - NegativeUNL: "nunl" : true
  - LedgerHashes: "hashes" : true (For the "short" list. See below.)

2. With RPC API >= 3, using special case values to "index", such as "index" : "amendments". Uses the same names as above. Note that for "hashes", this option will only return the recent ledger hashes / "short" skip list.

3. LedgerHashes has two types: "short", which stores recent ledger hashes, and "long", which stores the flag ledger hashes for a particular ledger range.
  - To find a "long" LedgerHashes object, request '"hashes" : <ledger sequence>'. <ledger sequence> must be a number that evaluates to an unsigned integer.
  - To find the "short" LedgerHashes object, request "hashes": true as with the other fixed objects.

The following queries are all functionally equivalent:

  - "amendments" : true
  - "index" : "amendments" (API >=3 only)
  - "amendments" : "7DB0788C020F02780A673DC74757F23823FA3014C1866E72CC4CD8B226CD6EF4"
  - "index" : "7DB0788C020F02780A673DC74757F23823FA3014C1866E72CC4CD8B226CD6EF4"

Finally, whether the object is found or not, if a valid index is computed, that index will be returned. This can be used to confirm the query was valid, or to save the index for future use.

ci: remove 'master' branch as a trigger (#6234)

This change removes the `master` branch as a trigger for the CI pipelines, and updates comments accordingly. It also fixes the pre-commit workflow, so it will run on all release branches.
bthomee pushed a commit that referenced this pull request Jan 22, 2026
…#6212)

This change continues the thread naming work from #5691 and #5758, which enables more useful lock contention profiling by ensuring threads/jobs have short, stable, human-readable names (rather than being truncated/failing due to OS limits). This changes diagnostic naming only (thread names and job/load-event labels), not behavior.

Specific modifications are:
* Shortens all thread/job names used with `beast::setCurrentThreadName`, so the effective Linux thread name stays within the 15-character limit.
* Removes per-ledger sequence numbers from job/thread names to avoid long labels. This improves aggregation in lock contention profiling for short-lived job executions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setCurrentThreadName fails silently if thread name string length longer than OS supports (Version: 2.5.0)

6 participants