Skip to content

Change LendingProtocol feature and dependencies to supported#5632

Merged
ximinez merged 2 commits intorelease-3.1from
ximinez/lending-enabled
Jan 13, 2026
Merged

Change LendingProtocol feature and dependencies to supported#5632
ximinez merged 2 commits intorelease-3.1from
ximinez/lending-enabled

Conversation

@ximinez
Copy link
Copy Markdown
Collaborator

@ximinez ximinez commented Jul 30, 2025

High Level Overview of Change

Change LendingProtocol feature and dependencies to Supported::yes. Enables testing.

Context of Change

LendingProtocol changes for version 3.1 are pending merge in #6156.

Type of Change

  • New feature (non-breaking change which adds functionality)

@ximinez ximinez force-pushed the ximinez/lending-enabled branch 3 times, most recently from 9f132dc to f056ace Compare August 6, 2025 01:34
@ximinez ximinez force-pushed the ximinez/lending-XLS-66 branch from 1bf68f7 to 1628756 Compare August 6, 2025 15:47
@ximinez ximinez force-pushed the ximinez/lending-enabled branch 3 times, most recently from e2544f0 to 5405712 Compare August 9, 2025 05:00
@ximinez ximinez force-pushed the ximinez/lending-enabled branch 2 times, most recently from 05414d1 to b6633a1 Compare August 18, 2025 22:16
@mvadari
Copy link
Copy Markdown
Collaborator

mvadari commented Aug 18, 2025

Hasn't the testing system been fixed to run on all amendments, not just the supported ones?

@ximinez ximinez force-pushed the ximinez/lending-XLS-66 branch from 7f478d9 to e62efa2 Compare August 19, 2025 00:35
@ximinez ximinez force-pushed the ximinez/lending-enabled branch 7 times, most recently from 4c64b87 to 8292ff0 Compare August 25, 2025 23:54
@ximinez ximinez force-pushed the ximinez/lending-enabled branch 4 times, most recently from 35d3ed2 to 7c8cc31 Compare August 29, 2025 22:09
@ximinez ximinez force-pushed the ximinez/lending-enabled branch 8 times, most recently from 34a594b to 16d949c Compare September 5, 2025 21:45
@ximinez ximinez force-pushed the ximinez/lending-enabled branch from aa765c6 to 78f8684 Compare September 29, 2025 22:44
@ximinez ximinez force-pushed the ximinez/lending-XLS-66 branch from ea79f66 to 7a3f7ae Compare September 30, 2025 01:43
@ximinez ximinez force-pushed the ximinez/lending-enabled branch 7 times, most recently from 4330470 to 6fd4b49 Compare October 3, 2025 02:12
@ximinez ximinez force-pushed the ximinez/lending-enabled branch 2 times, most recently from 60bc26c to b3a20c2 Compare October 10, 2025 17:04
@ximinez ximinez force-pushed the ximinez/lending-XLS-66 branch from c46d1f9 to 66dbc05 Compare October 10, 2025 17:22
@ximinez ximinez force-pushed the ximinez/lending-enabled branch 3 times, most recently from 056c4de to ea85aa2 Compare October 16, 2025 17:55
@ximinez ximinez force-pushed the ximinez/lending-enabled branch 4 times, most recently from 6701eed to 7b330e3 Compare October 23, 2025 17:28
@ximinez
Copy link
Copy Markdown
Collaborator Author

ximinez commented Dec 18, 2025

image

Note that I just rewrote this branch to be based on the release-3.1 and ximinez/lending-3.1 branches, which are the work in progress for (surprising no one) version 3.1.

This code is radically different than what it was previously, because it contains few or none of the non-Lending Protocol related changes that are pending in develop.

@ximinez ximinez mentioned this pull request Jan 7, 2026
9 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.4%. Comparing base (1ead5a7) to head (564a351).
⚠️ Report is 2 commits behind head on release-3.1.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           release-3.1   #5632   +/-   ##
===========================================
  Coverage         79.3%   79.4%           
===========================================
  Files              839     839           
  Lines            71716   71716           
  Branches          8275    8254   -21     
===========================================
+ Hits             56889   56914   +25     
+ Misses           14827   14802   -25     
Files with missing lines Coverage Δ
src/libxrpl/protocol/BuildInfo.cpp 98.1% <ø> (ø)

... and 6 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants