Add conan.lock by legleux · Pull Request #5596 · XRPLF/rippled

legleux · 2025-07-22T17:45:32Z

Adds a conan.lock file to freeze rippled's dependencies.

Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

codecov · 2025-07-22T20:23:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.8%. Comparing base (5c2a3a2) to head (0da5bc9).

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5596     +/-   ##
=========================================
- Coverage     78.8%   78.8%   -0.0%     
=========================================
  Files          814     814             
  Lines        71205   71204      -1     
  Branches      8330    8352     +22     
=========================================
- Hits         56111   56085     -26     
- Misses       15094   15119     +25

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Bronek · 2025-07-23T20:38:26Z

conan.lock

Can you pls add a subsection under https://github.com/XRPLF/rippled/blob/develop/CONTRIBUTING.md#instructions-for-maintainers how to update this file when we bump some dependency ?

Good point.

mathbunnyru

Agree with Bronek, please add instruction how to update the lockfile.
Just to make sure - you have ripple artifactory remote first, right?

Bronek · 2025-07-24T11:36:06Z

.github/workflows/nix.yml

    container: ghcr.io/xrplf/ci/debian-bookworm:clang-16
-
+    env:
+      CONAN_URL: http://18.143.149.228:8081/artifactory/api/conan/dev


shouldn't this be https, with actual DNS name ?

actually, I think this belongs to a different PR, one which also removes external Conan overrides, and corresponding conan export from workflows and from BUILD.md ?

shouldn't this be https, with actual DNS name ?

Wasn't pointing to the correct place at the time. It should be working now.

This one can be removed since it's already defined in the top-level env:.

legleux

Will push up changes with doc changes and workflow edits removed in since #5607

legleux · 2025-07-24T15:48:37Z

.github/workflows/nix.yml

    container: ghcr.io/xrplf/ci/debian-bookworm:clang-16
-
+    env:
+      CONAN_URL: http://18.143.149.228:8081/artifactory/api/conan/dev


shouldn't this be https, with actual DNS name ?

Wasn't pointing to the correct place at the time. It should be working now.

legleux · 2025-07-24T15:49:05Z

conan.lock

Good point.

bthomee · 2025-07-24T17:59:03Z

.github/workflows/nix.yml

 # to pollute conan/profiles directory with settings which might not work for others
 env:
+  build_dir: .build
  CONAN_URL: http://18.143.149.228:8081/artifactory/api/conan/dev


Can this be changed to https://conan.ripplex.io now?

bthomee · 2025-07-24T17:59:24Z

.github/workflows/nix.yml

    container: ghcr.io/xrplf/ci/debian-bookworm:clang-16
-
+    env:
+      CONAN_URL: http://18.143.149.228:8081/artifactory/api/conan/dev


This one can be removed since it's already defined in the top-level env:.

mathbunnyru · 2025-07-25T10:09:42Z

BUILD.md

   generator. Pass `--help` to see the rest of the command line options.


+#### Conan lockfile


Well, I've seen this before.
No, I've written this before 😃
https://github.com/XRPLF/clio/blob/develop/docs/build-clio.md#conan-lockfile

Why mess with perfection?

bthomee · 2025-07-25T19:40:57Z

BUILD.md

 - [Python 3.7](https://www.python.org/downloads/)
- [Conan 1.60](https://conan.io/downloads.html)[^1]
- [CMake 3.16](https://cmake.org/download/)
+- [Conan 2](https://conan.io/downloads.html)
+- [CMake 3.22](https://cmake.org/download/)


I would suggest to not make any changes here, as #5478 is already making them.

legleux marked this pull request as ready for review July 22, 2025 18:00

legleux force-pushed the legleux/conan_lockfile branch from ebc0afd to 8f20404 Compare July 22, 2025 19:38

legleux force-pushed the legleux/conan_lockfile branch 2 times, most recently from a61b2f5 to ba161cf Compare July 23, 2025 19:48

legleux requested review from Bronek, bthomee and mathbunnyru July 23, 2025 20:25

Bronek reviewed Jul 23, 2025

View reviewed changes

mathbunnyru reviewed Jul 24, 2025

View reviewed changes

Bronek reviewed Jul 24, 2025

View reviewed changes

Bronek mentioned this pull request Jul 24, 2025

Switch instrumentation workflow to use dependencies #5607

Merged

9 tasks

legleux commented Jul 24, 2025

View reviewed changes

bthomee reviewed Jul 24, 2025

View reviewed changes

legleux force-pushed the legleux/conan_lockfile branch from ba161cf to 0da5bc9 Compare July 25, 2025 02:34

mathbunnyru reviewed Jul 25, 2025

View reviewed changes

legleux force-pushed the legleux/conan_lockfile branch from 0da5bc9 to a441887 Compare July 25, 2025 17:29

Add conan.lock

8c711f3

legleux force-pushed the legleux/conan_lockfile branch from a441887 to 8c711f3 Compare July 25, 2025 17:43

bthomee reviewed Jul 25, 2025

View reviewed changes

mathbunnyru mentioned this pull request Sep 1, 2025

chore: Use conan lockfile #5751

Merged

13 tasks

legleux closed this Sep 2, 2025

legleux deleted the legleux/conan_lockfile branch September 16, 2025 21:45

		generator. Pass `--help` to see the rest of the command line options.


		#### Conan lockfile

Conversation

legleux commented Jul 22, 2025

Uh oh!

codecov bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Bronek Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mathbunnyru left a comment • edited by Bronek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

legleux Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

legleux left a comment

Choose a reason for hiding this comment

Uh oh!

legleux Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bthomee Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jul 22, 2025 •

edited

Loading

Bronek Jul 23, 2025 •

edited

Loading

mathbunnyru left a comment •

edited by Bronek

Loading

legleux Jul 24, 2025 •

edited

Loading

legleux Jul 24, 2025 •

edited

Loading

bthomee Jul 24, 2025 •

edited

Loading