Update BUILD for conan2 by Bronek · Pull Request #5478 · XRPLF/rippled

Bronek · 2025-06-06T12:31:35Z

High Level Overview of Change

Update BUILD.md for Conan 2, add fixes/workarounds for Apple Clang 17, Clang 20 and CMake 4

Context of Change

This also removes (from BUILD.md only) workarounds for compiler versions which we no longer support e.g. Clang 15 and adds compilation flag -Wno-deprecated-declarations to enable building with Clang 20 on Linux.

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Performance (increase or change in throughput and/or latency)
Tests (you added tests for code that already exists, or your new feature included in this PR)
Documentation update
Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
Release

codecov · 2025-06-06T13:05:33Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.8%. Comparing base (4eae037) to head (11862bd).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5478     +/-   ##
=========================================
- Coverage     78.8%   78.8%   -0.0%     
=========================================
  Files          814     814             
  Lines        71283   71282      -1     
  Branches      8349    8366     +17     
=========================================
- Hits         56172   56152     -20     
- Misses       15111   15130     +19

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

BUILD.md

external/grpc/patches/v1.50.x/003-fix-clang-template-error.patch

mathbunnyru · 2025-06-09T14:36:59Z

external/grpc/target_info/grpc_1.54.3.yml

@@ -0,0 +1,152 @@
+grpc_version: 1.54.3


Why are we adding patches for several versions?

Excellent question. Because that's what I happened to grab from conan-center-index. Removed the irrelevant versions in 87b6381

That's a perfect example why I like my solution with tools.build:cxxflags way more ;)

mathbunnyru

I left some comments in discussions, please take a look

BUILD.md

legleux · 2025-06-10T21:51:48Z

docs/build/environment.md

-
-pipx install 'conan<2'
-pipx ensurepath
+apt install --yes gcc-${GCC_RELEASE} g++-${GCC_RELEASE} python3-pip \


I'm guessing you did this in a container due to the lack of sudo but then the Python 3.11 in Debian 12 pip install conan command cries about needing --break-system-packages to install.

Thanks, will remember to add this option.

docs/build/environment.md

No longer applies

ximinez

I left some feedback, but overall, these instructions are fantastic. They got me migrated and up and running much faster than I expected.

ximinez · 2025-07-23T23:49:20Z

BUILD.md

+   ```bash
   conan export --version 1.1.10 external/snappy
   ```


Do you know why we don't specify the version of snappy in conanfile.py? We specify a version for (I think) all of the other dependencies. My build scripts pull the required version numbers out of conanfile.py. Not having it means I have to do it by hand, which isn't a big deal, unless we change the version we need.

That's because RocksDB specifies the version it its conanfile.py:

if self.options.with_snappy: self.requires("snappy/1.1.10")

See https://github.com/XRPLF/conan-center-index/blob/master/recipes/rocksdb/all/conanfile.py#L79.

ximinez · 2025-07-24T00:03:11Z

BUILD.md

+**Windows** developers also must select static runtime
+
+```bash
+sed -i.bak -e 's|^compiler\.runtime=.*$|compiler.runtime=static|' ~/.conan2/profiles/default
 ```


There's a part under "Build and Test" which includes overriding compiler.runtime for Windows. This seems to be completely unnecessary anymore. My Windows builds worked using the default instructions.

conan install .. --output-folder . --build missing --settings build_type=Release --settings compiler.runtime=MT conan install .. --output-folder . --build missing --settings build_type=Debug --settings compiler.runtime=MTd

In fact, we may be able to get rid of the bit starting with If you are using a Microsoft Visual C++ compiler, entirely.

It seems like Conan is managing to correctly set the runtime if you set the build_type. I might have to look again (and again).

I am wondering if we really need to use static runtime on Windows; the default is dynamic for good reasons (on Windows, shared libraries are much closer to executables than they are on Linux, and they have their own memory management - obviously within process VM space)

We switch to dynamic runtime for Windows to support updated protobuf and grpc versions here: #5589. In that PR I've removed this section.

BUILD.md

bthomee · 2025-07-25T18:25:28Z

docs/build/environment.md


-[1]: https://github.com/thejohnfreeman/rippled-docker/blob/master/ubuntu-22.04/install.sh
-
+If you use different Linux distribution, hope the instruction above can guide


How about we just point to the CI Dockerfiles instead of adding the instructions here? That way contributors can see what there system needs to build rippled, they can even use the images directly if they'd like, and we don't need to keep the instructions here in sync.

ximinez

Updates look good.

bthomee · 2025-08-05T17:10:15Z

@Bronek ready to merge?

Fix clang 20 compilation errors, update BUILD for conan2

2c7673d

Bronek force-pushed the Bronek/doc_conan2_cmake4 branch from d6149cf to 2c7673d Compare June 6, 2025 12:37

Bronek requested review from bthomee and intelliot June 6, 2025 12:39

Bronek mentioned this pull request Jun 6, 2025

build improve Apple M silicon support and add CMake option examples #5419

Closed

1 task

Bronek force-pushed the Bronek/doc_conan2_cmake4 branch 2 times, most recently from d779cad to b4f0deb Compare June 6, 2025 16:42

Bronek added 2 commits June 6, 2025 17:45

Update BUILD.md

1b3b00e

Switch -Wno-deprecated-declarations

41bf097

Bronek force-pushed the Bronek/doc_conan2_cmake4 branch from b4f0deb to 41bf097 Compare June 6, 2025 16:45

Bronek changed the title ~~Update BUILD for conan2~~ Update BUILD for conan2, clang-20 compatibility fixes Jun 6, 2025

Bronek requested a review from legleux June 6, 2025 17:00

Bronek force-pushed the Bronek/doc_conan2_cmake4 branch from 28d6f45 to fe3e732 Compare June 6, 2025 19:49

Update build environment instrictions for Conan 2

7342bb9

Bronek force-pushed the Bronek/doc_conan2_cmake4 branch from fe3e732 to 7342bb9 Compare June 6, 2025 19:51

mathbunnyru requested changes Jun 9, 2025

View reviewed changes

Bronek added 2 commits June 10, 2025 02:55

Better document --unittest-jobs

26b58f5

Review feedback

87b6381

Bronek requested a review from mathbunnyru June 9, 2025 19:08

mathbunnyru reviewed Jun 10, 2025

View reviewed changes

legleux approved these changes Jun 10, 2025

View reviewed changes

Bronek force-pushed the Bronek/doc_conan2_cmake4 branch 4 times, most recently from 821fff8 to 43579f8 Compare June 11, 2025 02:33

Review feedback

e3d3b00

Bronek force-pushed the Bronek/doc_conan2_cmake4 branch from 43579f8 to e3d3b00 Compare June 11, 2025 02:35

Bronek added 2 commits June 11, 2025 10:44

Remove nproc, won't work on MacOS by default

6b4b6f1

Unity build is not enabled by default in conanfile.py

f500f9b

Bronek force-pushed the Bronek/doc_conan2_cmake4 branch from 9948695 to 22fee37 Compare July 23, 2025 11:46

Bronek mentioned this pull request Jul 23, 2025

Rename conan profile to default #5599

Merged

9 tasks

Bronek added 3 commits July 23, 2025 15:12

Update BUILD.md

a4f36af

More workarounds and improved doc

04a3748

Merge branch 'develop' into Bronek/doc_conan2_cmake4

6dfae37

Merge branch 'develop' into Bronek/doc_conan2_cmake4

92db3ef

ximinez requested changes Jul 24, 2025

View reviewed changes

bthomee reviewed Jul 25, 2025

View reviewed changes

This was referenced Jul 25, 2025

Add conan.lock #5596

Closed

Remove external libraries as they are hosted in our conan center index fork #5643

Merged

bthomee and others added 4 commits July 31, 2025 18:40

Massage text

c003421

Add section on adding our Conan remote

9e8e0ac

Consolidate patched recipe instructions

2e6bd1a

Merge branch 'develop' into Bronek/doc_conan2_cmake4

cdb665e

bthomee approved these changes Aug 4, 2025

View reviewed changes

Bronek marked this pull request as ready for review August 4, 2025 15:29

Bronek requested a review from ximinez August 4, 2025 15:30

Bronek added 2 commits August 4, 2025 16:37

Minor

cbbdd95

Minor

f9e54df

ximinez approved these changes Aug 5, 2025

View reviewed changes

Merge branch 'develop' into Bronek/doc_conan2_cmake4

11862bd

Bronek added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Aug 6, 2025

bthomee enabled auto-merge (squash) August 6, 2025 10:09

bthomee merged commit dbeb841 into develop Aug 6, 2025
3 checks passed

bthomee deleted the Bronek/doc_conan2_cmake4 branch August 6, 2025 10:18

This was referenced Aug 27, 2025

Release 2.6.0 #5741

Merged

Release 2.6.0 #5742

Merged

mvadari mentioned this pull request Jan 30, 2026

In .github/workflow, bump gcc version to 12 (or later) and clang version to 16 (or later) #5153

Closed


		[1]: https://github.com/thejohnfreeman/rippled-docker/blob/master/ubuntu-22.04/install.sh

		If you use different Linux distribution, hope the instruction above can guide

Conversation

Bronek commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

High Level Overview of Change

Context of Change

Type of Change

Uh oh!

codecov bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mathbunnyru left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ximinez left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ximinez left a comment

Choose a reason for hiding this comment

Uh oh!

bthomee commented Aug 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Bronek commented Jun 6, 2025 •

edited

Loading

codecov bot commented Jun 6, 2025 •

edited

Loading

ximinez left a comment •

edited

Loading