Conversation
bthomee
approved these changes
Jul 18, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5581 +/- ##
=======================================
Coverage 78.8% 78.8%
=======================================
Files 814 814
Lines 71257 71259 +2
Branches 8365 8344 -21
=======================================
+ Hits 56132 56160 +28
+ Misses 15125 15099 -26
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ac71131 to
cfe675c
Compare
bthomee
approved these changes
Jul 21, 2025
ximinez
approved these changes
Jul 25, 2025
Collaborator
ximinez
left a comment
There was a problem hiding this comment.
Looks good, and builds for me without problems.
mvadari
pushed a commit
to mvadari/rippled
that referenced
this pull request
Jul 28, 2025
As we no longer support old compiler versions, we are bringing back some warnings by removing no longer relevant `-Wno-...` options.
bthomee
pushed a commit
that referenced
this pull request
Jul 31, 2025
As we no longer support old compiler versions, we are bringing back some warnings by removing no longer relevant `-Wno-...` options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Remove no longer relevant
-Wno-...optionsContext of Change
We no longer support old compiler versions, so we should bring back some warnings.
Type of Change
.gitignore, formatting, dropping support for older tooling)