Skip to content

fix: Do not link to several boost::stacktrace implementations because…#2329

Merged
mathbunnyru merged 2 commits intoXRPLF:developfrom
mathbunnyru:fix_odr
Jul 29, 2025
Merged

fix: Do not link to several boost::stacktrace implementations because…#2329
mathbunnyru merged 2 commits intoXRPLF:developfrom
mathbunnyru:fix_odr

Conversation

@mathbunnyru
Copy link
Copy Markdown
Collaborator

@mathbunnyru mathbunnyru commented Jul 14, 2025

… of rippled

See: XRPLF/rippled#5546

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.46%. Comparing base (d43002b) to head (364c608).
⚠️ Report is 22 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2329   +/-   ##
========================================
  Coverage    79.45%   79.46%           
========================================
  Files          378      378           
  Lines        15373    15373           
  Branches      7748     7748           
========================================
+ Hits         12215    12216    +1     
  Misses        1962     1962           
+ Partials      1196     1195    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kuznetsss
Copy link
Copy Markdown
Collaborator

kuznetsss commented Jul 14, 2025

Let's change the title to chore please

@mathbunnyru
Copy link
Copy Markdown
Collaborator Author

mathbunnyru commented Jul 14, 2025

Let's change the title to chore please

This fixes a bug in Clio, though

@mathbunnyru
Copy link
Copy Markdown
Collaborator Author

mathbunnyru commented Jul 14, 2025 •
edited
Loading

The intention of this commit is to actually fix the ODR problem, not just update a revision for the sake of being up to date.
I had a commit where I was just updating revisions: #2308 and it was chore.
This fix is definitely meaningful here.

@kuznetsss
Copy link
Copy Markdown
Collaborator

kuznetsss commented Jul 14, 2025

It doesn't change any logic inside Clio

@mathbunnyru
Copy link
Copy Markdown
Collaborator Author

mathbunnyru commented Jul 14, 2025

It doesn't change any logic inside Clio

It changes the logic how the symbolic stacktrace is produced when running clio.
And, because, having ODR is UB, I would say it changes the logic.

@mathbunnyru mathbunnyru mentioned this pull request Jul 14, 2025
Merged
godexsoft
godexsoft approved these changes Jul 17, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importance of chore or fix is too small to argue about it.

@godexsoft
Copy link
Copy Markdown
Collaborator

godexsoft commented Jul 29, 2025

are you merging this or something else is blocking it @mathbunnyru ?

@mathbunnyru mathbunnyru merged commit d7888d5 into XRPLF:develop Jul 29, 2025
163 of 164 checks passed
@mathbunnyru
Copy link
Copy Markdown
Collaborator Author

mathbunnyru commented Jul 29, 2025

Merged, thanks

mathbunnyru added a commit that referenced this pull request Jul 30, 2025
@mathbunnyru
feat: Use mold linker on Linux (#2304)
bc8a2c1 
Fix: #1242

Depends on: #2329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@godexsoft godexsoft godexsoft approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mathbunnyru @kuznetsss @godexsoft