Merged
Conversation
XLS-30: AMM Specification
intelliot
reviewed
Aug 15, 2023
Contributor
|
@aanchal4 - can you update this PR for the latest changes in AMM? For example, removing lsfAMM |
Co-authored-by: Elliot Lee <github.public@intelliot.com>
Co-authored-by: Elliot Lee <github.public@intelliot.com>
Co-authored-by: Elliot Lee <github.public@intelliot.com>
Co-authored-by: Elliot Lee <github.public@intelliot.com>
intelliot
approved these changes
Sep 6, 2023
gregtatcam
suggested changes
Sep 8, 2023
Silkjaer
approved these changes
Sep 13, 2023
gregtatcam
reviewed
Sep 26, 2023
Collaborator
gregtatcam
left a comment
There was a problem hiding this comment.
Looks good. I left two minor comments.
intelliot
reviewed
Sep 26, 2023
intelliot
reviewed
Sep 26, 2023
intelliot
reviewed
Sep 26, 2023
Co-authored-by: Elliot Lee <github.public@intelliot.com>
Co-authored-by: Elliot Lee <github.public@intelliot.com>
Co-authored-by: Elliot Lee <github.public@intelliot.com>
intelliot
added a commit
to aanchal4/XRPL-Standards
that referenced
this pull request
Oct 2, 2023
XLS-30 can be found here: XRPLF#125
Silkjaer
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior discussion about this spec can be found here: #78