Conversation
|
Links to issue #54 |
|
@matthewhillier tests verified as functioning? |
|
Hey @ReidWeb - No, still need to figure out how to actually load the names as they're not part of the static HTML any more. Haven't had time to dive in and figure that bit out. |
Basic fixes to unit tests, no mocking in-place yet.
|
Have figured out the basics here and implemented a change that pulls the various mounts & minions using the The code is functional and works as well as I can make it at the moment. Unit testing needs tightening up, but it should be good enough to use for the Sept census and all current tests pass. |
|
Thanks for this work! I'm just currently running a test. If everything's good then i'll deploy the changes this evening ahead of September. |
Pricetx
left a comment
There was a problem hiding this comment.
Test output looks to be correct. Approving.
* Adding test data and methods to call the new lodestone pages * Updated mount gathering * Added minion parsing * Added method to fetch tooltips from Lodestone * Stubbed out test method * Wired in Mount & Minion scraping * Updates to unit tests Basic fixes to unit tests, no mocking in-place yet.
Pull-request for new lodestone mounts & minions layout. Currently doesn't work, as there's a dependency on user-interaction in order for the details to actually load.