WordPress build: Add newlines after PHP annotations#986
Merged
Conversation
Merged
adamziel
added a commit
that referenced
this pull request
Jan 31, 2024
Rebuilds WordPress assets to include the changes from #986
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a newline character after every PHP annotation.
Rationale
Loading WordPress on PHP 7.4 yields the following error:
This is caused by the minification of PHP files via
php -w.PHP 8.0, which is currently used, outputs:
The class declaration is treated as a comment by PHP 7.4.
However, PHP 7.4 outputs:
Note the missing annotation.
Closes #985
Testing instructions
Confirm the CI tests pass