Footnotes: Trim footnote anchors from excerpts backport from Gutenberg#4845
Closed
ramonjd wants to merge 2 commits intoWordPress:trunkfrom
Closed
Footnotes: Trim footnote anchors from excerpts backport from Gutenberg#4845ramonjd wants to merge 2 commits intoWordPress:trunkfrom
ramonjd wants to merge 2 commits intoWordPress:trunkfrom
Conversation
…ntent. Adds tests
Member
Author
|
cc @mcsf Not sure if this is what you had in mind. Feel free to trash this one if so 😄 Also not sure if where I've put things is correct, e.g., different file? Different place in the excerpt formatting chain 🤷🏻 I probably need more tests too. Testing this PR surface a couple of bugs, e.g., WordPress/gutenberg#52628 |
costdev
reviewed
Jul 14, 2023
costdev
reviewed
Jul 14, 2023
costdev
reviewed
Jul 14, 2023
Prefer PHP 8's str_contains
Contributor
I've responded in Trac already, but yeah, this is great! :) |
Contributor
ramonjd
added a commit
to WordPress/gutenberg
that referenced
this pull request
Jul 18, 2023
ramonjd
added a commit
to WordPress/gutenberg
that referenced
this pull request
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports changes from WordPress/gutenberg#52518
Adding a function to
wp_trim_excerptthat removes footnotes from content.Adds tests
Trac ticket: https://core.trac.wordpress.org/ticket/58805
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.