Prefer $navigation_post->found_posts to count( $navigation_post->posts )#4733
Closed
ramonjd wants to merge 1 commit intoWordPress:trunkfrom
Closed
Prefer $navigation_post->found_posts to count( $navigation_post->posts )#4733ramonjd wants to merge 1 commit intoWordPress:trunkfrom
ramonjd wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Member
Author
|
Never mind, this doesn't work found_posts is 0 in the tests. Will return for a follow up another time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on feedback from #4713 (review)
Let's use the found_posts property.
Props @mukeshpanchal27
Trac ticket: https://core.trac.wordpress.org/ticket/58557
Gutenberg backport over here: WordPress/gutenberg#51999
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.