Backport to WP 6.3 - Navigation fallbacks from 4648#4713
Closed
ramonjd wants to merge 16 commits intoWordPress:trunkfrom
Closed
Backport to WP 6.3 - Navigation fallbacks from 4648#4713ramonjd wants to merge 16 commits intoWordPress:trunkfrom
ramonjd wants to merge 16 commits intoWordPress:trunkfrom
Conversation
This may not be the correct location. Can be moved subject to discussion.
This was referenced Jun 27, 2023
|
|
||
| $navigation_post = new WP_Query( $parsed_args ); | ||
|
|
||
| if ( count( $navigation_post->posts ) > 0 ) { |
Member
There was a problem hiding this comment.
Suggested change
| if ( count( $navigation_post->posts ) > 0 ) { | |
| if ( $navigation_post->found_posts > 0 ) { |
Instead of count use found_posts
Member
Author
There was a problem hiding this comment.
Thanks @mukeshpanchal27
Makes sense to me.
Looks like this has been committed. I'll do a follow up after Beta 1.
Member
Author
There was a problem hiding this comment.
Core class: #4733
Updating Gutenberg: WordPress/gutenberg#51999
Member
Author
There was a problem hiding this comment.
Might have to follow up another day actually
$navigation_post->found_posts returns 0 and I haven't got time to dig around. Sorry!
Contributor
This was referenced Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds files relating to Navigation fallbacks for the block editor.
This PR brings #4648 over in its entirety but with updated fixtures.
Props @getdave
Trac ticket: https://core.trac.wordpress.org/ticket/58557
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.