Skip to content

Enable block theme live preview button#4376

Closed
ajlende wants to merge 2 commits intoWordPress:trunkfrom
ajlende:add/enable-block-theme-live-preview-button
Closed

Enable block theme live preview button#4376
ajlende wants to merge 2 commits intoWordPress:trunkfrom
ajlende:add/enable-block-theme-live-preview-button

Conversation

@ajlende
Copy link
Copy Markdown

@ajlende ajlende commented Apr 25, 2023

Trac ticket: https://core.trac.wordpress.org/ticket/58190

Enables the 'Live Preview' button for block themes and use the theme_preview query param from WordPress/gutenberg#41836 to preview the theme.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

MaggieCabrera added a commit to MaggieCabrera/wordpress-develop that referenced this pull request Jun 16, 2023
MaggieCabrera added a commit to MaggieCabrera/wordpress-develop that referenced this pull request Jun 27, 2023
@annezazu
Copy link
Copy Markdown

annezazu commented Dec 7, 2024

@ajlende what happened here? Does this still need to be done? Discovered this and am confused by why it's still open/whether it was backported: https://core.trac.wordpress.org/ticket/58190 I can see a live preview after installing a theme so curious if this is about adding it before installing.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @alex@lende.xyz.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props annezazu.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ajlende
Copy link
Copy Markdown
Author

ajlende commented Dec 18, 2024

Looks like the code was backported in https://core.trac.wordpress.org/ticket/58561

@ajlende ajlende closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants