REST API: Small optimizations to filtering by context#424
Closed
dlh01 wants to merge 3 commits intoWordPress:masterfrom
Closed
REST API: Small optimizations to filtering by context#424dlh01 wants to merge 3 commits intoWordPress:masterfrom
dlh01 wants to merge 3 commits intoWordPress:masterfrom
Conversation
Contributor
|
Merged into WP Core in https://core.trac.wordpress.org/changeset/48555 |
mrinal013
added a commit
to mrinal013/wordpress-develop
that referenced
this pull request
Aug 24, 2023
In the @nirav7707's PR, at twentytwentyone/functions.php line WordPress#424, 433 wp_register_script() missed array at 6th paramerter. Here, added this. Ticket: https://core.trac.wordpress.org/ticket/58634
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attached patch proposes some minor optimizations to
rest_filter_response_by_context()and adds a few tests.Trac ticket: https://core.trac.wordpress.org/ticket/50700
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.