Skip to content

Help/About: Update font sizes and spacing on About section.#2681

Closed
ryelle wants to merge 4 commits intoWordPress:trunkfrom
ryelle:update/60-about-design
Closed

Help/About: Update font sizes and spacing on About section.#2681
ryelle wants to merge 4 commits intoWordPress:trunkfrom
ryelle:update/60-about-design

Conversation

@ryelle
Copy link
Copy Markdown
Contributor

@ryelle ryelle commented May 5, 2022

Trac ticket: https://core.trac.wordpress.org/ticket/55434

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@ryelle ryelle self-assigned this May 5, 2022
@ryelle ryelle force-pushed the update/60-about-design branch from 6222584 to bef8042 Compare May 10, 2022 02:37
@ryelle
Copy link
Copy Markdown
Contributor Author

ryelle commented May 10, 2022 •
edited
Loading

Updated headers for the other About sections:

Freedoms

Privacy

ETA: Just realized I did the credits page incorrectly, fixing

Credits

peterwilsoncc
peterwilsoncc approved these changes May 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me testing in the browser.

Testing notes
✅ Behaves responsively
✅ text size, spacing increased
✅ SVG images reasonably well compressed (SVGOMG could save 50 bytes of each but I suspect that was rounding numbers down)

@ryelle
Copy link
Copy Markdown
Contributor Author

ryelle commented May 10, 2022

Updated the image source to use the s.w.org CDN 👍🏻

SVG images reasonably well compressed (SVGOMG could save 50 bytes of each but I suspect that was rounding numbers down)

They've all been through SVGOMG already - the biggest change was removing focusable, which is technically not necessary but I'm adding it to these SVGs to keep it consistent with the change to the "6.0" SVG in #2683.

@ryelle
Copy link
Copy Markdown
Contributor Author

ryelle commented May 10, 2022

Committed in r53382.

@ryelle ryelle closed this May 10, 2022
@ryelle ryelle deleted the update/60-about-design branch May 17, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergeyBiryukov SergeyBiryukov SergeyBiryukov approved these changes

@peterwilsoncc peterwilsoncc peterwilsoncc approved these changes

Assignees

@ryelle ryelle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryelle @SergeyBiryukov @peterwilsoncc