Update styles of Welcome Panel to match 6.0 About design#2683
Closed
ryelle wants to merge 6 commits intoWordPress:trunkfrom
Closed
Update styles of Welcome Panel to match 6.0 About design#2683ryelle wants to merge 6 commits intoWordPress:trunkfrom
ryelle wants to merge 6 commits intoWordPress:trunkfrom
Conversation
This inlines the SVG onto the dashboard, so that we can style it using CSS. It also introduces 3 new color variables to control the dashboard colors.
peterwilsoncc
requested changes
May 10, 2022
Contributor
peterwilsoncc
left a comment
There was a problem hiding this comment.
Testing notes:
✅ Ensured colours change depending on user theme
✅ Tested responsive behaivour using the ol' change the size of the browser window technique
✅ confirmed customiser/site editor links were displayed depending on theme type
✅ labouriously used English spelling in each of these bullet points because I was in a mood ;)
Visually it's great, thank you!
I've left one note inline about how the file is included, once that's changed I reckon it's good to go in.
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
SergeyBiryukov
approved these changes
May 10, 2022
hellofromtonya
approved these changes
May 10, 2022
Contributor
hellofromtonya
left a comment
There was a problem hiding this comment.
LGTM - ready for commit.
Contributor
Author
|
Committed in r53383. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This inlines the 6.0 SVG onto the dashboard, so that we can style it using CSS. It also introduces 3 new color variables to control the dashboard colors, which removes the light scheme workaround in
_admin.scss.Trac ticket: https://core.trac.wordpress.org/ticket/55532
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.