Build: Change the source for wp-polyfill#1361
Closed
gziolo wants to merge 2 commits intoWordPress:masterfrom
gziolo:update/babel-polyfill
Closed
Build: Change the source for wp-polyfill#1361gziolo wants to merge 2 commits intoWordPress:masterfrom gziolo:update/babel-polyfill
wp-polyfill#1361gziolo wants to merge 2 commits intoWordPress:masterfrom
gziolo:update/babel-polyfill
Conversation
Member
Author
|
I tested on macOS Big Sur with the latest:
Everything works as expected. |
Contributor
|
Looks good, what's the different in terms of Kb? |
youknowriad
reviewed
Jun 10, 2021
Member
Author
|
When I move to dependencies: "@wordpress/babel-preset-default": "6.2.0",I get the following error:
I'm not sure why it's happening :( Can we keep it as |
Contributor
the error is weird but yeah we can keep there if it solves it. |
pierlon
added a commit
to ampproject/amp-wp
that referenced
this pull request
Jun 14, 2021
…fault/build/polyfill` See WordPress/gutenberg#31279 See WordPress/wordpress-develop#1361
Member
|
Just wanted to record the difference in file size here for historical reference: BeforeUnminified file: 242KB AfterUnminified file: 53KB |
Member
|
Merged into Core in https://core.trac.wordpress.org/changeset/51146. |
pierlon
added a commit
to ampproject/amp-wp
that referenced
this pull request
Aug 31, 2021
…fault/build/polyfill` See WordPress/gutenberg#31279 See WordPress/wordpress-develop#1361
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/52941
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.