Formatting: Add capital Eszett (ẞ → SS) to remove_accents() for German locale#11188
Closed
apermo wants to merge 4 commits intoWordPress:trunkfrom
Closed
Formatting: Add capital Eszett (ẞ → SS) to remove_accents() for German locale#11188apermo wants to merge 4 commits intoWordPress:trunkfrom
apermo wants to merge 4 commits intoWordPress:trunkfrom
Conversation
Adds ẞ (U+1E9E) → SS to the German locale block, mirroring the existing ß → ss entry. Standardized in German orthography in 2017 (DIN 5008). Fixes #64821.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
reviewed
Mar 6, 2026
Member
dmsnell
left a comment
There was a problem hiding this comment.
looks good, except the comment should be updated. I can add that if you want.
Adds ẞ (U+1E9E) to the German locale table in the docblock and adds a @SInCE tag for the 7.1.0 addition. See #64821.
The target version is not yet determined. See #64821.
apermo
added a commit
to apermo/gutenberg
that referenced
this pull request
Mar 6, 2026
Mirrors WordPress/wordpress-develop#11188 which adds the same mapping to PHP remove_accents(). ẞ (U+1E9E) was standardized in German orthography in 2017 (DIN 5008) and should map to SS, not fall through to URL-encoded output.
pento
pushed a commit
that referenced
this pull request
Mar 6, 2026
The capital Eszett was standardized in German orthography in 2017, DIN 5008, but WordPress has only been transforming the lowercase version. This patch adds the uppercase variant to the list and transforms it to “SS” for more-appriate slug and permalink generation. Developed in: #11188 Discussed in: https://core.trac.wordpress.org/ticket/64821 Props apermo, dmsnell. Fixes #64821. git-svn-id: https://develop.svn.wordpress.org/trunk@61855 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 6, 2026
The capital Eszett was standardized in German orthography in 2017, DIN 5008, but WordPress has only been transforming the lowercase version. This patch adds the uppercase variant to the list and transforms it to “SS” for more-appriate slug and permalink generation. Developed in: WordPress/wordpress-develop#11188 Discussed in: https://core.trac.wordpress.org/ticket/64821 Props apermo, dmsnell. Fixes #64821. Built from https://develop.svn.wordpress.org/trunk@61855 git-svn-id: http://core.svn.wordpress.org/trunk@61142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ẞ(U+1E9E, LATIN CAPITAL LETTER SHARP S) →SSto the German locale block inremove_accents(), directly after the existingß→ssentry.The uppercase ß was officially standardized in German orthography in 2017 (DIN 5008 revision). This is an edge case — ẞ appears almost exclusively in all-caps contexts such as street names and official documents — but it is included for completeness and consistency: every other character in the German locale block has both its upper and lowercase form mapped.
Without this fix,
ẞfalls through without a mapping and is returned unchanged, leading to URL-encoded characters in slugs:Trac ticket: https://core.trac.wordpress.org/ticket/64821
Use of AI Tools
This patch was developed with the assistance of Claude Code (Anthropic). The change, test case, and Trac ticket were reviewed and approved by the contributor before submission.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.