Deprecate addslashes_gpc function and add unit tests.#10771
Closed
rutviksavsani wants to merge 8 commits into
Closed
Deprecate addslashes_gpc function and add unit tests.#10771rutviksavsani wants to merge 8 commits into
rutviksavsani wants to merge 8 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
reviewed
Jan 22, 2026
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
westonruter
approved these changes
Jan 23, 2026
mindctrl
approved these changes
Jan 23, 2026
audrasjb
approved these changes
Feb 1, 2026
audrasjb
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me as well.
Author
|
@audrasjb @westonruter @mindctrl Thanks for the reviews. |
Member
|
I'm happy to do so. |
pento
pushed a commit
that referenced
this pull request
Feb 4, 2026
This deprecates `addslashes_gpc()` in favor of `wp_slash()`, as the former is just a wrapper for the latter. The three remaining uses of `addslashes_gpc()` (in `WP_Query`) have been replaced with `wp_slash()`. Unit tests are added to verify that they have the same behavior. Developed in #10771 Follow-up to [23591], [23555]. Props rutviksavsani, audrasjb, westonruter, mindctrl, johnbillion. See #21767. Fixes #64539. git-svn-id: https://develop.svn.wordpress.org/trunk@61590 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Feb 4, 2026
This deprecates `addslashes_gpc()` in favor of `wp_slash()`, as the former is just a wrapper for the latter. The three remaining uses of `addslashes_gpc()` (in `WP_Query`) have been replaced with `wp_slash()`. Unit tests are added to verify that they have the same behavior. Developed in WordPress/wordpress-develop#10771 Follow-up to [23591], [23555]. Props rutviksavsani, audrasjb, westonruter, mindctrl, johnbillion. See #21767. Fixes #64539. Built from https://develop.svn.wordpress.org/trunk@61590 git-svn-id: http://core.svn.wordpress.org/trunk@60901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
markjaquith
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Feb 18, 2026
This deprecates `addslashes_gpc()` in favor of `wp_slash()`, as the former is just a wrapper for the latter. The three remaining uses of `addslashes_gpc()` (in `WP_Query`) have been replaced with `wp_slash()`. Unit tests are added to verify that they have the same behavior. Developed in WordPress/wordpress-develop#10771 Follow-up to [23591], [23555]. Props rutviksavsani, audrasjb, westonruter, mindctrl, johnbillion. See #21767. Fixes #64539. Built from https://develop.svn.wordpress.org/trunk@61590 git-svn-id: http://core.svn.wordpress.org/trunk@60901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
jihaisse
pushed a commit
to jihaisse/wordpress-develop
that referenced
this pull request
Feb 18, 2026
This deprecates `addslashes_gpc()` in favor of `wp_slash()`, as the former is just a wrapper for the latter. The three remaining uses of `addslashes_gpc()` (in `WP_Query`) have been replaced with `wp_slash()`. Unit tests are added to verify that they have the same behavior. Developed in WordPress#10771 Follow-up to [23591], [23555]. Props rutviksavsani, audrasjb, westonruter, mindctrl, johnbillion. See #21767. Fixes #64539. git-svn-id: https://develop.svn.wordpress.org/trunk@61590 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, we are deprecating the
addslashes_gpcfunction as it was just a wrapper function towp_slashAdditionally, I have added PHPUnit tests for the same as well, let me know if they are not required and I can remove it.
Trac ticket: https://core.trac.wordpress.org/ticket/64539
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.