Change the order of the build#10283
Closed
aaronjorbin wants to merge 1 commit into
Closed
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
approved these changes
Oct 20, 2025
dmsnell
left a comment
Member
There was a problem hiding this comment.
For the sake of freeing up merges without CI errors I support this change. We can follow-up with the root issue causing the TypeScript errors.
pento
pushed a commit
that referenced
this pull request
Oct 20, 2025
Because of a strange interaction with building Gutenberg from within the plugins directory, TypeScript was appearing to examine code for which it should have no access up the filesystem hierarchy. This patch changes the order of building Gutenberg so that it occurs before those parent directories contain TypeScript code (by installing the `npm` dependencies) and thus frees up the builds. This change should not serve as a workaround to avoid fixing the root issue, introduced in WordPress/gutenberg@8401993. Rather, it should be seen as at least a temporary way to remove the trigger of the problem during CI builds. See also alternative work: - To build Gutenberg outside of the plugin directory in https://github.com/WordPress/wordpress-develop/pull/10282/files. - To patch the broken `@wordpress/blocks` types inside of `@wordpress/core-data`. Developed in #10283 Props czarate, desrosj, dmsnell, ellatrix, jorbin, peterwilsoncc, ramonopoly, westonruter, youknowriad. git-svn-id: https://develop.svn.wordpress.org/trunk@60985 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Oct 20, 2025
Because of a strange interaction with building Gutenberg from within the plugins directory, TypeScript was appearing to examine code for which it should have no access up the filesystem hierarchy. This patch changes the order of building Gutenberg so that it occurs before those parent directories contain TypeScript code (by installing the `npm` dependencies) and thus frees up the builds. This change should not serve as a workaround to avoid fixing the root issue, introduced in WordPress/gutenberg@8401993. Rather, it should be seen as at least a temporary way to remove the trigger of the problem during CI builds. See also alternative work: - To build Gutenberg outside of the plugin directory in https://github.com/WordPress/wordpress-develop/pull/10282/files. - To patch the broken `@wordpress/blocks` types inside of `@wordpress/core-data`. Developed in WordPress/wordpress-develop#10283 Props czarate, desrosj, dmsnell, ellatrix, jorbin, peterwilsoncc, ramonopoly, westonruter, youknowriad. Built from https://develop.svn.wordpress.org/trunk@60985 git-svn-id: http://core.svn.wordpress.org/trunk@60321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions Bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Oct 20, 2025
Because of a strange interaction with building Gutenberg from within the plugins directory, TypeScript was appearing to examine code for which it should have no access up the filesystem hierarchy. This patch changes the order of building Gutenberg so that it occurs before those parent directories contain TypeScript code (by installing the `npm` dependencies) and thus frees up the builds. This change should not serve as a workaround to avoid fixing the root issue, introduced in WordPress/gutenberg@8401993. Rather, it should be seen as at least a temporary way to remove the trigger of the problem during CI builds. See also alternative work: - To build Gutenberg outside of the plugin directory in https://github.com/WordPress/wordpress-develop/pull/10282/files. - To patch the broken `@wordpress/blocks` types inside of `@wordpress/core-data`. Developed in WordPress/wordpress-develop#10283 Props czarate, desrosj, dmsnell, ellatrix, jorbin, peterwilsoncc, ramonopoly, westonruter, youknowriad. Built from https://develop.svn.wordpress.org/trunk@60985 git-svn-id: https://core.svn.wordpress.org/trunk@60321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #10282
See WordPress/gutenberg#72450
Attempt to fix the CI