Include a fix for alternate login forms.#62
Conversation
In situations where login_header() is inaccessible (because we’re on a page other than wp-login.php because of a plugin or something) manually redefine `login_header()` so we can call it there as well. Also make sure we’re always submitting to the correct page and links go to the correct page — `wp_login_url()` — if a plugin changes that, they should also be reordering things to call the actions we use so that it still works. Resolves issues with WooCommerce logins from front-end pages. 👍 Fixes #61
There was a problem hiding this comment.
Incidentally, when I first wrote this, I don't know why I thought wp-includes/functions.wp-login.php existed -- it never has best as I can tell.
|
There is no other way than to duplicate the |
|
The core |
|
Just speaking out load here, but how would we overcome this issue during merge if we can't get the functions moved out of |
|
The other option is to just I agree that we may need to implement something else for mergeability, but for the moment, this suffices. cc: @markjaquith for input on core architecture and such. |
|
Did some testing with WooCommerce and everything looks good. |
Include a fix for alternate login forms.
In situations where login_header() is inaccessible (because we’re on a
page other than wp-login.php because of a plugin or something) manually
redefine
login_header()so we can call it there as well.Also make sure we’re always submitting to the correct page and links go
to the correct page —
wp_login_url()— if a plugin changes that, theyshould also be reordering things to call the actions we use so that it
still works.
Resolves issues with WooCommerce logins from front-end pages. 👍
Fixes #61